[GitHub] [incubator-superset] opus-42 commented on pull request #10760: feat(viz): export csv with frontend the same name

[GitBox <gi...@apache.org>]

opus-42 commented on pull request #10760:
URL: https://github.com/apache/incubator-superset/pull/10760#issuecomment-703871517


   Hello @chuancyzhang. Thank you for your merge request, this is much needed for the end users.
   I would suggest the following update to your merge request:
   - Using the `df.rename` function from pandas would do the jobs rather than an inline for loop
   - You could as well include metrics and "Time" because the issue does also exist in the same way for metric names.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org