You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/13 11:28:51 UTC
[GitHub] [shardingsphere-elasticjob] y553546436 opened a new pull request #1774: Update GsonFactoryTest.java
y553546436 opened a new pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774
Remove potential test order dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN closed pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
TeslaCN closed pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-743994780
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=h1) Report
> Merging [#1774](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=desc) (3887750) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/d287daef279213dfd3be3d2ef9bd4a332b0b9677?el=desc) (d287dae) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1774 +/- ##
============================================
- Coverage 85.98% 85.84% -0.14%
Complexity 110 110
============================================
Files 268 268
Lines 5907 5907
Branches 911 911
============================================
- Hits 5079 5071 -8
- Misses 497 502 +5
- Partials 331 334 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ener/AbstractDistributeOnceElasticJobListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2xpc3RlbmVyL0Fic3RyYWN0RGlzdHJpYnV0ZU9uY2VFbGFzdGljSm9iTGlzdGVuZXIuamF2YQ==) | `75.86% <0.00%> (-6.90%)` | `0.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `92.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=footer). Last update [d287dae...3887750](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-744160032
Hi @y553546436 ,
I see what you mean now. But on the one hand, register another TypeAdapter cannot eliminate the impact, unless you remove the registered TypeAdapter from GsonBuilder. On the other hand, `GsonFactoryTest` is just a simple unit test class should not be used by other testcase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-748985988
Close due to no response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] y553546436 commented on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
y553546436 commented on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-744125342
> Hi @y553546436 ,
>
> I can't get your point. Could you clarify what the problem is?
Hi @TeslaCN, this test modifies GsonFactory, which contains (static) fields shared among tests. If other tests are added later on which assume the default behavior of GsonFactory, they would fail. In another word, this test "pollutes" the shared program state and could potentially lead other tests run after it to fail. Though there is no severe problem now, it would be good to clean the state (remove the "pollution") at the end of the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-743994780
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=h1) Report
> Merging [#1774](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=desc) (3887750) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/d287daef279213dfd3be3d2ef9bd4a332b0b9677?el=desc) (d287dae) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1774 +/- ##
=========================================
Coverage 85.98% 85.98%
Complexity 110 110
=========================================
Files 268 268
Lines 5907 5907
Branches 911 911
=========================================
Hits 5079 5079
Misses 497 497
Partials 331 331
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=footer). Last update [d287dae...3887750](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] y553546436 commented on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
y553546436 commented on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-855911653
**Comment that I will post in the old PR after I open this new PR**
Sorry that I didn't follow up because I did not receive the notification email from GitHub.
Indeed, this PR is of poor quality because (1) it lacks good description, (2) it does not follow your PR template (one PR points to one issue), and (3) the code does not fully remove the pollution, as you have commented.
I sincerely apologize for my carelessness, and have opened a new PR that addresses the above three issues: #1901.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] y553546436 edited a comment on pull request #1774: Update GsonFactoryTest.java
Posted by GitBox <gi...@apache.org>.
y553546436 edited a comment on pull request #1774:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1774#issuecomment-855911653
Sorry that I didn't follow up because I did not receive the notification email from GitHub.
Indeed, this PR is of poor quality because (1) it lacks good description, (2) it does not follow your PR template (one PR points to one issue), and (3) the code does not fully remove the pollution, as you have commented.
I sincerely apologize for my carelessness, and have opened a new PR that addresses the above three issues: #1901.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org