[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #24357: Polish test code.

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on code in PR #24357:
URL: https://github.com/apache/shardingsphere/pull/24357#discussion_r1120213756


##########
infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/user/GranteeTest.java:
##########
@@ -46,9 +46,9 @@ public void assertEquals() {
         Grantee grantee = new Grantee("name", "%");
         Grantee grantee1 = new Grantee("name", "");
         Grantee grantee2 = new Grantee("name", "127.0.0.1");
-        assertTrue(grantee.equals(grantee1));
-        assertTrue(grantee.equals(grantee2));
-        assertFalse(grantee.equals(new Object()));
+        Assert.assertEquals(grantee, grantee1);
+        Assert.assertEquals(grantee, grantee2);
+        assertNotEquals(grantee, new Object());

Review Comment:
   Please use static mock for Assert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org