[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #177: [MPLUGIN-443] Detect javadoc link labels with spaces

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #177:
URL: https://github.com/apache/maven-plugin-tools/pull/177#discussion_r1036020183


##########
maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocReferenceTest.java:
##########
@@ -45,6 +45,8 @@ void testParse()
                       JavadocReference.parse( "package.Class#member(ArgType1,ArgType2) label" ) );
         assertEquals( new JavadocReference( Optional.of("my.module"), Optional.of( "package.Class" ), Optional.of( "member(ArgType1,ArgType2)" ), Optional.of("label") ),
                       JavadocReference.parse( "my.module/package.Class#member(ArgType1,ArgType2) label" ) );
+        assertEquals( new JavadocReference( Optional.empty(), Optional.empty(), Optional.of( "member" ), Optional.of("label with spaces") ),
+                JavadocReference.parse( "#member label with spaces" ) );

Review Comment:
   My bad, but this id/anchor contains spaces...?!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org