You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/04/07 02:17:31 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1412: [CELEBORN-507] don't set up worker endpoint when update meta and remove compare meta with workers
RexXiong opened a new pull request, #1412:
URL: https://github.com/apache/incubator-celeborn/pull/1412
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
1. Remove setup worker endpoint
2. Remove Compare workerInfos
### Why are the changes needed?
1. Should not set up endpoint while updateWorkerHeartbeatMeta while this will potentially block celeborn master startup progress.
2. Remove Compare workerInfos, as Heartbeat will keep them consist.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong merged pull request #1412: [CELEBORN-507] don't set up worker endpoint when update meta and remove compare meta with workers
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong merged PR #1412:
URL: https://github.com/apache/incubator-celeborn/pull/1412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1412: [CELEBORN-507] don't set up worker endpoint when update meta and remove compare meta with workers
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1412:
URL: https://github.com/apache/incubator-celeborn/pull/1412#issuecomment-1499872273
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1412?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1412](https://codecov.io/gh/apache/incubator-celeborn/pull/1412?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec3c57a) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/bbd5d0ef5c07755f22ddeacf462ca563e7e883b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bbd5d0e) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
+ Coverage 45.01% 45.04% +0.04%
==========================================
Files 164 164
Lines 10404 10405 +1
Branches 1057 1057
==========================================
+ Hits 4682 4686 +4
+ Misses 5382 5381 -1
+ Partials 340 338 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/celeborn/common/meta/WorkerInfo.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvV29ya2VySW5mby5zY2FsYQ==) | `61.75% <100.00%> (+1.61%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1412/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org