You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2011/11/21 22:29:01 UTC
Review Request: OOZIE-607 Pig POM brings in several unneeded dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Excluding unneeded Pig dependencies. (Pig testcases pass)
This addresses bug OOZIE-607.
https://issues.apache.org/jira/browse/OOZIE-607
Diffs
-----
/trunk/pom.xml 1204713
/trunk/sharelib/pom.xml 1204713
Diff: https://reviews.apache.org/r/2902/diff
Testing
-------
Thanks,
Alejandro
Re: Review Request: OOZIE-607 Pig POM brings in several unneeded dependencies
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On 2011-11-21 22:13:31, Virag Kothari wrote:
> > /trunk/sharelib/pom.xml, line 79
> > <https://reviews.apache.org/r/2902/diff/1/?file=59634#file59634line79>
> >
> > Can you explain why the scope is changed from runtime to compile?
> >
> > These libraries are picked at run time when pig related test cases are executed.
> > They are not used during compilation.
you are correct, and the same goes for jline, guava & antlr.
uploading a new patch in a few mins.
Thxs.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/#review3407
-----------------------------------------------------------
On 2011-11-21 21:29:01, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2902/
> -----------------------------------------------------------
>
> (Updated 2011-11-21 21:29:01)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Excluding unneeded Pig dependencies. (Pig testcases pass)
>
>
> This addresses bug OOZIE-607.
> https://issues.apache.org/jira/browse/OOZIE-607
>
>
> Diffs
> -----
>
> /trunk/pom.xml 1204713
> /trunk/sharelib/pom.xml 1204713
>
> Diff: https://reviews.apache.org/r/2902/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-607 Pig POM brings in several unneeded dependencies
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/#review3407
-----------------------------------------------------------
/trunk/sharelib/pom.xml
<https://reviews.apache.org/r/2902/#comment7633>
Can you explain why the scope is changed from runtime to compile?
These libraries are picked at run time when pig related test cases are executed.
They are not used during compilation.
- Virag
On 2011-11-21 21:29:01, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2902/
> -----------------------------------------------------------
>
> (Updated 2011-11-21 21:29:01)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Excluding unneeded Pig dependencies. (Pig testcases pass)
>
>
> This addresses bug OOZIE-607.
> https://issues.apache.org/jira/browse/OOZIE-607
>
>
> Diffs
> -----
>
> /trunk/pom.xml 1204713
> /trunk/sharelib/pom.xml 1204713
>
> Diff: https://reviews.apache.org/r/2902/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-607 Pig POM brings in several unneeded dependencies
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/#review3422
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2011-11-21 22:32:23, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2902/
> -----------------------------------------------------------
>
> (Updated 2011-11-21 22:32:23)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Excluding unneeded Pig dependencies. (Pig testcases pass)
>
>
> This addresses bug OOZIE-607.
> https://issues.apache.org/jira/browse/OOZIE-607
>
>
> Diffs
> -----
>
> /trunk/pom.xml 1204713
> /trunk/sharelib/pom.xml 1204713
>
> Diff: https://reviews.apache.org/r/2902/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-607 Pig POM brings in several unneeded dependencies
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2902/
-----------------------------------------------------------
(Updated 2011-11-21 22:32:23.495642)
Review request for oozie.
Changes
-------
updated patch changing deps of pig from compile to runtime.
Summary
-------
Excluding unneeded Pig dependencies. (Pig testcases pass)
This addresses bug OOZIE-607.
https://issues.apache.org/jira/browse/OOZIE-607
Diffs (updated)
-----
/trunk/pom.xml 1204713
/trunk/sharelib/pom.xml 1204713
Diff: https://reviews.apache.org/r/2902/diff
Testing
-------
Thanks,
Alejandro