You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Karan Malhi <ka...@gmail.com> on 2011/07/17 07:03:07 UTC

issues with patches

Whatever happened to that nice "Issues with Patches" report we used to get?

-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Ranga S <sr...@yahoo.com>.
Hi Mark

Thanks.
I don't know for sure. Since I haven't explicitly specified a scope, it is whatever the default is (Dependent?). I create an EJBContainer in my test. How do I destroy the context in this case?


- Ranga


________________________________
From: Mark Struberg <st...@yahoo.de>
To: dev@openejb.apache.org; Ranga S <sr...@yahoo.com>
Sent: Monday, July 18, 2011 1:39 AM
Subject: Re: @Disposes

The @Disposes will get called once the Context gets destroyed. For a @RequestScoped bean thats at the end of the request.
Are you sure the context gets cleaned up?

lLieGrue,
strub

--- On Mon, 7/18/11, Ranga S <sr...@yahoo.com> wrote:

> From: Ranga S <sr...@yahoo.com>
> Subject: Re: @Disposes
> To: "dev@openejb.apache.org" <de...@openejb.apache.org>
> Date: Monday, July 18, 2011, 5:33 AM
> Hi Karan
> 
> Could you assign the following JIRA ticket to me? I'll
> upload the code to the ticket.
> https://issues.apache.org/jira/browse/OPENEJB-1613
> 
> 
> - Ranga
> 
> 
> ________________________________
> From: Karan Malhi <ka...@gmail.com>
> To: dev@openejb.apache.org;
> Ranga S <sr...@yahoo.com>
> Sent: Sunday, July 17, 2011 8:25 PM
> Subject: Re: @Disposes
> 
> Hi Ranga,
> 
> Is it possible to share the code? Might make it a bit
> easier to
> discuss the issue and extend some suggestions on it.
> 
> On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com>
> wrote:
> > Hi
> >
> > I am trying to get an example working with the
> "@Disposes" annotation. The "@Produces" method gets invoked
> properly. However, the "@Disposes" method doesn't get
> invoked. I don't see any errors either.
> > Could someone help me out?
> >
> >
> > - Ranga
> 
> 
> 
> -- 
> 
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Ranga S <sr...@yahoo.com>.
Thanks Karan.
I've uploaded a patch to the ticket. Please take a look. (LogFactory, LoggerImpl, LoggerTest).

- Ranga


________________________________
From: Karan Malhi <ka...@gmail.com>
To: dev@openejb.apache.org; Ranga S <sr...@yahoo.com>
Sent: Monday, July 18, 2011 3:33 AM
Subject: Re: @Disposes

Done

On Mon, Jul 18, 2011 at 1:33 AM, Ranga S <sr...@yahoo.com> wrote:
> Hi Karan
>
> Could you assign the following JIRA ticket to me? I'll upload the code to the ticket.
> https://issues.apache.org/jira/browse/OPENEJB-1613
>
>
> - Ranga
>
>
> ________________________________
> From: Karan Malhi <ka...@gmail.com>
> To: dev@openejb.apache.org; Ranga S <sr...@yahoo.com>
> Sent: Sunday, July 17, 2011 8:25 PM
> Subject: Re: @Disposes
>
> Hi Ranga,
>
> Is it possible to share the code? Might make it a bit easier to
> discuss the issue and extend some suggestions on it.
>
> On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com> wrote:
>> Hi
>>
>> I am trying to get an example working with the "@Disposes" annotation. The "@Produces" method gets invoked properly. However, the "@Disposes" method doesn't get invoked. I don't see any errors either.
>> Could someone help me out?
>>
>>
>> - Ranga
>
>
>
> --
>
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Karan Malhi <ka...@gmail.com>.
Done

On Mon, Jul 18, 2011 at 1:33 AM, Ranga S <sr...@yahoo.com> wrote:
> Hi Karan
>
> Could you assign the following JIRA ticket to me? I'll upload the code to the ticket.
> https://issues.apache.org/jira/browse/OPENEJB-1613
>
>
> - Ranga
>
>
> ________________________________
> From: Karan Malhi <ka...@gmail.com>
> To: dev@openejb.apache.org; Ranga S <sr...@yahoo.com>
> Sent: Sunday, July 17, 2011 8:25 PM
> Subject: Re: @Disposes
>
> Hi Ranga,
>
> Is it possible to share the code? Might make it a bit easier to
> discuss the issue and extend some suggestions on it.
>
> On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com> wrote:
>> Hi
>>
>> I am trying to get an example working with the "@Disposes" annotation. The "@Produces" method gets invoked properly. However, the "@Disposes" method doesn't get invoked. I don't see any errors either.
>> Could someone help me out?
>>
>>
>> - Ranga
>
>
>
> --
>
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Mark Struberg <st...@yahoo.de>.
The @Disposes will get called once the Context gets destroyed. For a @RequestScoped bean thats at the end of the request.
Are you sure the context gets cleaned up?

lLieGrue,
strub

--- On Mon, 7/18/11, Ranga S <sr...@yahoo.com> wrote:

> From: Ranga S <sr...@yahoo.com>
> Subject: Re: @Disposes
> To: "dev@openejb.apache.org" <de...@openejb.apache.org>
> Date: Monday, July 18, 2011, 5:33 AM
> Hi Karan
> 
> Could you assign the following JIRA ticket to me? I'll
> upload the code to the ticket.
> https://issues.apache.org/jira/browse/OPENEJB-1613
> 
> 
> - Ranga
> 
> 
> ________________________________
> From: Karan Malhi <ka...@gmail.com>
> To: dev@openejb.apache.org;
> Ranga S <sr...@yahoo.com>
> Sent: Sunday, July 17, 2011 8:25 PM
> Subject: Re: @Disposes
> 
> Hi Ranga,
> 
> Is it possible to share the code? Might make it a bit
> easier to
> discuss the issue and extend some suggestions on it.
> 
> On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com>
> wrote:
> > Hi
> >
> > I am trying to get an example working with the
> "@Disposes" annotation. The "@Produces" method gets invoked
> properly. However, the "@Disposes" method doesn't get
> invoked. I don't see any errors either.
> > Could someone help me out?
> >
> >
> > - Ranga
> 
> 
> 
> -- 
> 
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Mark Struberg <st...@yahoo.de>.
The @Disposes will get called once the Context gets destroyed. For a @RequestScoped bean thats at the end of the request.
Are you sure the context gets cleaned up?

lLieGrue,
strub

--- On Mon, 7/18/11, Ranga S <sr...@yahoo.com> wrote:

> From: Ranga S <sr...@yahoo.com>
> Subject: Re: @Disposes
> To: "dev@openejb.apache.org" <de...@openejb.apache.org>
> Date: Monday, July 18, 2011, 5:33 AM
> Hi Karan
> 
> Could you assign the following JIRA ticket to me? I'll
> upload the code to the ticket.
> https://issues.apache.org/jira/browse/OPENEJB-1613
> 
> 
> - Ranga
> 
> 
> ________________________________
> From: Karan Malhi <ka...@gmail.com>
> To: dev@openejb.apache.org;
> Ranga S <sr...@yahoo.com>
> Sent: Sunday, July 17, 2011 8:25 PM
> Subject: Re: @Disposes
> 
> Hi Ranga,
> 
> Is it possible to share the code? Might make it a bit
> easier to
> discuss the issue and extend some suggestions on it.
> 
> On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com>
> wrote:
> > Hi
> >
> > I am trying to get an example working with the
> "@Disposes" annotation. The "@Produces" method gets invoked
> properly. However, the "@Disposes" method doesn't get
> invoked. I don't see any errors either.
> > Could someone help me out?
> >
> >
> > - Ranga
> 
> 
> 
> -- 
> 
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Ranga S <sr...@yahoo.com>.
Hi Karan

Could you assign the following JIRA ticket to me? I'll upload the code to the ticket.
https://issues.apache.org/jira/browse/OPENEJB-1613


- Ranga


________________________________
From: Karan Malhi <ka...@gmail.com>
To: dev@openejb.apache.org; Ranga S <sr...@yahoo.com>
Sent: Sunday, July 17, 2011 8:25 PM
Subject: Re: @Disposes

Hi Ranga,

Is it possible to share the code? Might make it a bit easier to
discuss the issue and extend some suggestions on it.

On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com> wrote:
> Hi
>
> I am trying to get an example working with the "@Disposes" annotation. The "@Produces" method gets invoked properly. However, the "@Disposes" method doesn't get invoked. I don't see any errors either.
> Could someone help me out?
>
>
> - Ranga



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Karan Malhi <ka...@gmail.com>.
Hi Ranga,

Is it possible to share the code? Might make it a bit easier to
discuss the issue and extend some suggestions on it.

On Sun, Jul 17, 2011 at 9:17 PM, Ranga S <sr...@yahoo.com> wrote:
> Hi
>
> I am trying to get an example working with the "@Disposes" annotation. The "@Produces" method gets invoked properly. However, the "@Disposes" method doesn't get invoked. I don't see any errors either.
> Could someone help me out?
>
>
> - Ranga



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: @Disposes

Posted by Ranga S <sr...@yahoo.com>.
Hi

I am trying to get an example working with the "@Disposes" annotation. The "@Produces" method gets invoked properly. However, the "@Disposes" method doesn't get invoked. I don't see any errors either.
Could someone help me out?


- Ranga

Re: issues with patches

Posted by David Blevins <da...@gmail.com>.
I had it setup as a cron job in people.a.o but at some point it failed after one of the upgrades and never had the time to investigate.

Turns out it was just that infra switched us to https from http and the redirect was messing up swizzle.  Regardless, if someone else is interested in providing the care and feeding, excellent :)

I checked in the ingredients here:

 https://svn.apache.org/repos/asf/openejb/trunk/sandbox/jirareports

At one point I had this setup for a few projects.  Some asked me to disable them and then when it broke I disabled them all.  Whoever takes it over, feel free to poke some of the projects in the cron.txt and ask them if they want their reports back.  Or not.  Whatever time allows :)  They could also probably set them up themselves, which might scale better.

-David


On Jul 17, 2011, at 9:06 AM, Mohammad Nour El-Din wrote:

> that would be much better for time available to me :D
> 
> On Sun, Jul 17, 2011 at 4:37 PM, Karan Malhi <ka...@gmail.com> wrote:
>> That would be great. I think earlier we used to get that email on a
>> Monday, if we could get it on Friday evening, becomes a bit easier to
>> look at patch submissions it over the weekend
>> 
>> On Sun, Jul 17, 2011 at 5:15 AM, Mohammad Nour El-Din
>> <no...@gmail.com> wrote:
>>> Good idea, I can look into that, but according to my current work load
>>> I will not be able to get back w/ results until next Tuesday, if thats
>>> OK I will do it.
>>> 
>>> On Sun, Jul 17, 2011 at 7:03 AM, Karan Malhi <ka...@gmail.com> wrote:
>>>> Whatever happened to that nice "Issues with Patches" report we used to get?
>>>> 
>>>> --
>>>> 
>>>> Karan Singh Malhi
>>>> twitter.com/KaranSinghMalhi
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> Thanks
>>> - Mohammad Nour
>>>   Author of (WebSphere Application Server Community Edition 2.0 User Guide)
>>>   http://www.redbooks.ibm.com/abstracts/sg247585.html
>>> - LinkedIn: http://www.linkedin.com/in/mnour
>>> - Blog: http://tadabborat.blogspot.com
>>> ----
>>> "Life is like riding a bicycle. To keep your balance you must keep moving"
>>> - Albert Einstein
>>> 
>>> "Writing clean code is what you must do in order to call yourself a
>>> professional. There is no reasonable excuse for doing anything less
>>> than your best."
>>> - Clean Code: A Handbook of Agile Software Craftsmanship
>>> 
>>> "Stay hungry, stay foolish."
>>> - Steve Jobs
>>> 
>> 
>> 
>> 
>> --
>> 
>> Karan Singh Malhi
>> twitter.com/KaranSinghMalhi
>> 
> 
> 
> 
> -- 
> Thanks
> - Mohammad Nour
>   Author of (WebSphere Application Server Community Edition 2.0 User Guide)
>   http://www.redbooks.ibm.com/abstracts/sg247585.html
> - LinkedIn: http://www.linkedin.com/in/mnour
> - Blog: http://tadabborat.blogspot.com
> ----
> "Life is like riding a bicycle. To keep your balance you must keep moving"
> - Albert Einstein
> 
> "Writing clean code is what you must do in order to call yourself a
> professional. There is no reasonable excuse for doing anything less
> than your best."
> - Clean Code: A Handbook of Agile Software Craftsmanship
> 
> "Stay hungry, stay foolish."
> - Steve Jobs


Re: issues with patches

Posted by Mohammad Nour El-Din <no...@gmail.com>.
that would be much better for time available to me :D

On Sun, Jul 17, 2011 at 4:37 PM, Karan Malhi <ka...@gmail.com> wrote:
> That would be great. I think earlier we used to get that email on a
> Monday, if we could get it on Friday evening, becomes a bit easier to
> look at patch submissions it over the weekend
>
> On Sun, Jul 17, 2011 at 5:15 AM, Mohammad Nour El-Din
> <no...@gmail.com> wrote:
>> Good idea, I can look into that, but according to my current work load
>> I will not be able to get back w/ results until next Tuesday, if thats
>> OK I will do it.
>>
>> On Sun, Jul 17, 2011 at 7:03 AM, Karan Malhi <ka...@gmail.com> wrote:
>>> Whatever happened to that nice "Issues with Patches" report we used to get?
>>>
>>> --
>>>
>>> Karan Singh Malhi
>>> twitter.com/KaranSinghMalhi
>>>
>>
>>
>>
>> --
>> Thanks
>> - Mohammad Nour
>>   Author of (WebSphere Application Server Community Edition 2.0 User Guide)
>>   http://www.redbooks.ibm.com/abstracts/sg247585.html
>> - LinkedIn: http://www.linkedin.com/in/mnour
>> - Blog: http://tadabborat.blogspot.com
>> ----
>> "Life is like riding a bicycle. To keep your balance you must keep moving"
>> - Albert Einstein
>>
>> "Writing clean code is what you must do in order to call yourself a
>> professional. There is no reasonable excuse for doing anything less
>> than your best."
>> - Clean Code: A Handbook of Agile Software Craftsmanship
>>
>> "Stay hungry, stay foolish."
>> - Steve Jobs
>>
>
>
>
> --
>
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi
>



-- 
Thanks
- Mohammad Nour
  Author of (WebSphere Application Server Community Edition 2.0 User Guide)
  http://www.redbooks.ibm.com/abstracts/sg247585.html
- LinkedIn: http://www.linkedin.com/in/mnour
- Blog: http://tadabborat.blogspot.com
----
"Life is like riding a bicycle. To keep your balance you must keep moving"
- Albert Einstein

"Writing clean code is what you must do in order to call yourself a
professional. There is no reasonable excuse for doing anything less
than your best."
- Clean Code: A Handbook of Agile Software Craftsmanship

"Stay hungry, stay foolish."
- Steve Jobs

Re: issues with patches

Posted by Karan Malhi <ka...@gmail.com>.
That would be great. I think earlier we used to get that email on a
Monday, if we could get it on Friday evening, becomes a bit easier to
look at patch submissions it over the weekend

On Sun, Jul 17, 2011 at 5:15 AM, Mohammad Nour El-Din
<no...@gmail.com> wrote:
> Good idea, I can look into that, but according to my current work load
> I will not be able to get back w/ results until next Tuesday, if thats
> OK I will do it.
>
> On Sun, Jul 17, 2011 at 7:03 AM, Karan Malhi <ka...@gmail.com> wrote:
>> Whatever happened to that nice "Issues with Patches" report we used to get?
>>
>> --
>>
>> Karan Singh Malhi
>> twitter.com/KaranSinghMalhi
>>
>
>
>
> --
> Thanks
> - Mohammad Nour
>   Author of (WebSphere Application Server Community Edition 2.0 User Guide)
>   http://www.redbooks.ibm.com/abstracts/sg247585.html
> - LinkedIn: http://www.linkedin.com/in/mnour
> - Blog: http://tadabborat.blogspot.com
> ----
> "Life is like riding a bicycle. To keep your balance you must keep moving"
> - Albert Einstein
>
> "Writing clean code is what you must do in order to call yourself a
> professional. There is no reasonable excuse for doing anything less
> than your best."
> - Clean Code: A Handbook of Agile Software Craftsmanship
>
> "Stay hungry, stay foolish."
> - Steve Jobs
>



-- 

Karan Singh Malhi
twitter.com/KaranSinghMalhi

Re: issues with patches

Posted by Mohammad Nour El-Din <no...@gmail.com>.
Good idea, I can look into that, but according to my current work load
I will not be able to get back w/ results until next Tuesday, if thats
OK I will do it.

On Sun, Jul 17, 2011 at 7:03 AM, Karan Malhi <ka...@gmail.com> wrote:
> Whatever happened to that nice "Issues with Patches" report we used to get?
>
> --
>
> Karan Singh Malhi
> twitter.com/KaranSinghMalhi
>



-- 
Thanks
- Mohammad Nour
  Author of (WebSphere Application Server Community Edition 2.0 User Guide)
  http://www.redbooks.ibm.com/abstracts/sg247585.html
- LinkedIn: http://www.linkedin.com/in/mnour
- Blog: http://tadabborat.blogspot.com
----
"Life is like riding a bicycle. To keep your balance you must keep moving"
- Albert Einstein

"Writing clean code is what you must do in order to call yourself a
professional. There is no reasonable excuse for doing anything less
than your best."
- Clean Code: A Handbook of Agile Software Craftsmanship

"Stay hungry, stay foolish."
- Steve Jobs