You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/21 15:24:00 UTC

[jira] [Work logged] (BEAM-14347) [Go SDK] Allow users to optimize DoFns with a single generic registration function

     [ https://issues.apache.org/jira/browse/BEAM-14347?focusedWorklogId=760127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760127 ]

ASF GitHub Bot logged work on BEAM-14347:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Apr/22 15:23
            Start Date: 21/Apr/22 15:23
    Worklog Time Spent: 10m 
      Work Description: damccorm opened a new pull request, #17429:
URL: https://github.com/apache/beam/pull/17429

   This is the first step towards allowing users to fully replace the code generator with a DoFn registration function (design doc https://docs.google.com/document/d/1MLZLUhb-Sn7AJ666yn3TnYgMKE6wiXIBs7cjB_20hMA/edit?usp=sharing). Generally, this accomplishes this by:
   
   - Updating to Go 1.18
   - Adding registration.tmpl to generate registration.go with a bunch of arity specific registration functions. At the moment, these register struct wrappers, types, and funcs for the passed in DoFn.
   - Update specialize/main.go to provide some functions used by registration.tmpl
   
   Because the tmpl file is hard to review in isolation, I would do so with the generated file side by side so that you can see how the template translates into the final code.
   
   **Next steps**
   
   After this is in, I will follow up with prs to:
   
   1. Handle emitter/iter registration
   2. Handle combiner registration
   3. Perf testing
   4. Updates to the docs/our examples
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 760127)
    Remaining Estimate: 0h
            Time Spent: 10m

> [Go SDK] Allow users to optimize DoFns with a single generic registration function
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-14347
>                 URL: https://issues.apache.org/jira/browse/BEAM-14347
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-go
>            Reporter: Danny McCormick
>            Assignee: Danny McCormick
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Right now, to optimize DoFn execution, users have to use the code generator. This updates to allow them to use generics instead.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)