[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #8418: Flask App factory PR #1

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #8418: Flask App factory PR #1
URL: https://github.com/apache/incubator-superset/pull/8418#discussion_r347553034
 
 

 ##########
 File path: superset/__init__.py
 ##########
 @@ -14,229 +14,43 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-# pylint: disable=C,R,W
 """Package's main module!"""
-import json
-import logging
-import os
-from copy import deepcopy
-from typing import Any, Dict
+from flask import current_app, Flask
+from werkzeug.local import LocalProxy
 
-import wtforms_json
-from flask import Flask, redirect
-from flask_appbuilder import AppBuilder, IndexView, SQLA
-from flask_appbuilder.baseviews import expose
-from flask_compress import Compress
-from flask_migrate import Migrate
-from flask_talisman import Talisman
-from flask_wtf.csrf import CSRFProtect
-
-from superset import config
+from superset.app import create_app
 from superset.connectors.connector_registry import ConnectorRegistry
+from superset.extensions import (
+    appbuilder as ab,
+    cache_manager,
+    db as ext_db,
+    event_logger as ext_event_logger,
+    feature_flag_manager,
+    manifest_processor,
+    results_backend_manager,
+    security_manager as ext_security_manager,
+    talisman as ext_talisman,
 
 Review comment:
   For clarity at this point. I suppose I could have just imported `extensions` and then referenced each item upon assignment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org