[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin
URL: https://github.com/apache/hadoop-ozone/pull/105#discussion_r340470980
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
 ##########
 @@ -87,6 +87,10 @@
   private String[] args;
   private volatile AtomicBoolean isStopped = new AtomicBoolean(false);
 
+  public HddsDatanodeService(){
+    this(false, new String[] {});
 
 Review comment:
   Calling the other constructor is unnecessary, the default values for `printBanner` (`false`) and `args` (`null`) are fine.
   
   On the other hand, can you please add a comment that this constructor is required for `ServicePlugin` implementation?  This would help later to avoid accidentally removing it again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org