You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jason Dillon (JIRA)" <ji...@apache.org> on 2006/06/26 01:09:29 UTC

[jira] Created: (GSHELL-13) Implement command search path

Implement command search path
-----------------------------

         Key: GSHELL-13
         URL: http://issues.apache.org/jira/browse/GSHELL-13
     Project: GShell (Sandbox)
        Type: Improvement
    Security: public (Regular issues) 
  Components: Core  
    Versions: 0.0.1    
    Reporter: Jason Dillon
 Assigned to: Jason Dillon 


Command search path.

 * ~/.gshell/
 * profile.gsh
 * settings.gsh?  settings.properties?  settings.xml?


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon reassigned GSHELL-13:
----------------------------------

    Assignee: Jason Dillon

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-1
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564254#action_12564254 ] 

jdillon edited comment on GSHELL-13 at 1/30/08 5:38 PM:
-------------------------------------------------------------

Yup, you can put any GShell commands into:

 * {{~/.gshell/gshell.profile}}
 * {{~/.gshell/gshell.rc}}

{{gshell.profile}} is always executed, {{gshell.rc}} is only executed if the shell is interactive.

So you can:

{noformat}
set path=foo:bar
{noformat}

      was (Author: jdillon):
    Yup, you can put any GShell commands into:

 * {{~/.gshell/gshell.profile}}
 * {{~/.gshell/gshell.rc}}

{{gshell.profile}} is always executed, {{gshell.rc}} is only executed if the shell is interactive.

So you can:

{noformat}
set PATH foo:bar
{noformat}
  
> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-13.patch
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-13) Implement command search path

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GSHELL-13:
-------------------------------

    Attachment: GShell-13.patch

This implements the beginnings of command path search.  An environment variable "path" can be set so that commands can be used without fully qualifying the path every time (i.e, script instead of bsf/script).  An issue I came across is that the "set" command doesn't like when you try to add to the path via path=$path:bsf.  This causes an error and the path isn't set properly.

Can gshell load environmental variables from a .profile type file, yet?  Having a persistent path based on such a file would be neat.  If it doesn't exist, I might just have to look into it.

As a side note, I made the command path work such that you can always access the builtins in case someone accidentally mucks up their path.  I did that during testing and none of the commands could be found, including quit (ctrl + c to the rescue!).



> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-13.patch
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon updated GSHELL-13:
-------------------------------

    Assignee:     (was: Jason Dillon)

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>             Fix For: 1.0-alpha-1
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon reassigned GSHELL-13:
----------------------------------

    Assignee: Jason Dillon  (was: Jason Warner)

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-13.patch
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon closed GSHELL-13.
------------------------------

    Resolution: Fixed

Yay... this is a good first step.  I think we might want to decide on some naming things for variables used by gshell.  Like I'm thinking instead of {{path}} this should be {{gshell.path}}.

Also, we need to fix how {{/}}, {{./}} and {{../}} are handled.  Cause this is a bit weird to me:

{noformat}
set path=/:vfs
{noformat}

IMO, should be:

{noformat}
set path=/:/vfs
{noformat}

And finally, we really need more tests for this stuff... like what happens when 2 paths have the same command name?  Does the command found in the path before the other really get used?...

Yatta!

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-13.patch
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564254#action_12564254 ] 

Jason Dillon commented on GSHELL-13:
------------------------------------

Yup, you can put any GShell commands into:

 * {{~/.gshell/gshell.profile}}
 * {{~/.gshell/gshell.rc}}

{{gshell.profile}} is always executed, {{gshell.rc}} is only executed if the shell is interactive.

So you can:

{noformat}
set PATH foo:bar
{noformat}

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-13.patch
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564257#action_12564257 ] 

Jason Dillon commented on GSHELL-13:
------------------------------------

A minor nit... please make sure your patches have the correct indent ;-)  4 spaces, no tabs.

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>         Attachments: GShell-13.patch
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GSHELL-13) Implement command search path

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner reassigned GSHELL-13:
----------------------------------

    Assignee: Jason Warner  (was: Jason Dillon)

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Warner
>             Fix For: 1.0-alpha-2
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GSHELL-13) Implement command search path

Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GSHELL-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dillon updated GSHELL-13:
-------------------------------

    Fix Version/s:     (was: 1.0-alpha-1)
                   1.0-alpha-2

> Implement command search path
> -----------------------------
>
>                 Key: GSHELL-13
>                 URL: https://issues.apache.org/jira/browse/GSHELL-13
>             Project: GShell
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Core
>    Affects Versions: 0.0.1
>            Reporter: Jason Dillon
>            Assignee: Jason Dillon
>             Fix For: 1.0-alpha-2
>
>
> Command search path.
>  * ~/.gshell/
>  * profile.gsh
>  * settings.gsh?  settings.properties?  settings.xml?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.