You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Mark Struberg <st...@yahoo.de.INVALID> on 2017/05/19 10:56:23 UTC
Move CipherService etc to the security module?
While writing the documentation to the new cipher feature (DELTASPIKE-1250) I thought about moving the feature from core to the security module.
It's probably good to avoid bloating the core module even further.
Any thoughts on that?
LieGrue,
strub
Re: Move CipherService etc to the security module?
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Is perfectly fine for me - thanks for the feedback!
LieGrue,
strub
> Am 19.05.2017 um 20:35 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> We agree, my point was that adding it to security module to get this
> feature would kill this feature IMHO so keeping it in core is pby saner for
> now.
>
>
> Le 19 mai 2017 08:58, "Mark Struberg" <st...@yahoo.de.invalid> a écrit :
>
>> Hi Romain!
>>
>> Imo it's an orthogonal feature.
>>
>> Of course it makes perfect sense to e.g. use it in a ConfigFilter to try
>> to decrypt everything which is e.g. prefixed with a "crypt:".
>> But it also makes sense to be used in totally different areas. Like e.g.
>> manually decrypting the password for a connection, etc.
>>
>> I'm perfectly fine both ways, so we can also let it as is (core) as it is
>> not really lots of code.
>>
>> LieGrue,
>> strub
>>
>>> Am 19.05.2017 um 14:19 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
>>> :
>>>
>>> Is it ok to not be usable with config? Think it belongs to config more
>> than
>>> anything else no? Security is something else.
>>>
>>>
>>> Le 19 mai 2017 06:56, "Mark Struberg" <st...@yahoo.de.invalid> a
>> écrit :
>>>
>>>> While writing the documentation to the new cipher feature
>>>> (DELTASPIKE-1250) I thought about moving the feature from core to the
>>>> security module.
>>>> It's probably good to avoid bloating the core module even further.
>>>>
>>>> Any thoughts on that?
>>>>
>>>> LieGrue,
>>>> strub
>>
>>
Re: Move CipherService etc to the security module?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
We agree, my point was that adding it to security module to get this
feature would kill this feature IMHO so keeping it in core is pby saner for
now.
Le 19 mai 2017 08:58, "Mark Struberg" <st...@yahoo.de.invalid> a écrit :
> Hi Romain!
>
> Imo it's an orthogonal feature.
>
> Of course it makes perfect sense to e.g. use it in a ConfigFilter to try
> to decrypt everything which is e.g. prefixed with a "crypt:".
> But it also makes sense to be used in totally different areas. Like e.g.
> manually decrypting the password for a connection, etc.
>
> I'm perfectly fine both ways, so we can also let it as is (core) as it is
> not really lots of code.
>
> LieGrue,
> strub
>
> > Am 19.05.2017 um 14:19 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> >
> > Is it ok to not be usable with config? Think it belongs to config more
> than
> > anything else no? Security is something else.
> >
> >
> > Le 19 mai 2017 06:56, "Mark Struberg" <st...@yahoo.de.invalid> a
> écrit :
> >
> >> While writing the documentation to the new cipher feature
> >> (DELTASPIKE-1250) I thought about moving the feature from core to the
> >> security module.
> >> It's probably good to avoid bloating the core module even further.
> >>
> >> Any thoughts on that?
> >>
> >> LieGrue,
> >> strub
>
>
Re: Move CipherService etc to the security module?
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Hi Romain!
Imo it's an orthogonal feature.
Of course it makes perfect sense to e.g. use it in a ConfigFilter to try to decrypt everything which is e.g. prefixed with a "crypt:".
But it also makes sense to be used in totally different areas. Like e.g. manually decrypting the password for a connection, etc.
I'm perfectly fine both ways, so we can also let it as is (core) as it is not really lots of code.
LieGrue,
strub
> Am 19.05.2017 um 14:19 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> Is it ok to not be usable with config? Think it belongs to config more than
> anything else no? Security is something else.
>
>
> Le 19 mai 2017 06:56, "Mark Struberg" <st...@yahoo.de.invalid> a écrit :
>
>> While writing the documentation to the new cipher feature
>> (DELTASPIKE-1250) I thought about moving the feature from core to the
>> security module.
>> It's probably good to avoid bloating the core module even further.
>>
>> Any thoughts on that?
>>
>> LieGrue,
>> strub
Re: Move CipherService etc to the security module?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Is it ok to not be usable with config? Think it belongs to config more than
anything else no? Security is something else.
Le 19 mai 2017 06:56, "Mark Struberg" <st...@yahoo.de.invalid> a écrit :
> While writing the documentation to the new cipher feature
> (DELTASPIKE-1250) I thought about moving the feature from core to the
> security module.
> It's probably good to avoid bloating the core module even further.
>
> Any thoughts on that?
>
> LieGrue,
> strub