You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/09/03 08:15:30 UTC
[GitHub] [cassandra-in-jvm-dtest-api] krummas opened a new pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests
krummas opened a new pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] krummas commented on a change in pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests
Posted by GitBox <gi...@apache.org>.
krummas commented on a change in pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13#discussion_r484836359
##########
File path: src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -268,6 +274,14 @@ public B withInstanceInitializer(BiConsumer<ClassLoader, Integer> instanceInitia
return (B) this;
}
+ public B withDataDirCount(int datadirCount)
+ {
+ assert datadirCount > 0;
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] krummas merged pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests
Posted by GitBox <gi...@apache.org>.
krummas merged pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13#discussion_r483891478
##########
File path: src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -268,6 +274,14 @@ public B withInstanceInitializer(BiConsumer<ClassLoader, Integer> instanceInitia
return (B) this;
}
+ public B withDataDirCount(int datadirCount)
+ {
+ assert datadirCount > 0;
Review comment:
would be nice to leave a message, like `"data dir count requires a positive number but given " + datadirCount`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] krummas commented on a change in pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests
Posted by GitBox <gi...@apache.org>.
krummas commented on a change in pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13#discussion_r484835030
##########
File path: src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -54,6 +54,7 @@
private ClassLoader sharedClassLoader = Thread.currentThread().getContextClassLoader();
private int broadcastPort = 7012;
private BiConsumer<ClassLoader, Integer> instanceInitializer = (cl, id) -> {};
+ private int datadirCount = 3;
Review comment:
yeah I want it to be 3 by default to make sure we exercise the range splitting code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13#discussion_r483891564
##########
File path: src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -54,6 +54,7 @@
private ClassLoader sharedClassLoader = Thread.currentThread().getContextClassLoader();
private int broadcastPort = 7012;
private BiConsumer<ClassLoader, Integer> instanceInitializer = (cl, id) -> {};
+ private int datadirCount = 3;
Review comment:
not sure if we should stay at 1 (match previous logic) or keep this... would make sure tests run with multi dir by default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org