You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/10/12 17:02:01 UTC

[PR] CAMEL-25564: Telegram - send the webhook secret token in the webhook test [camel-quarkus]

oscerd opened a new pull request, #9317:
URL: https://github.com/apache/camel-quarkus/pull/9317

   ## Description
   
   [CAMEL-25564](https://issues.apache.org/jira/browse/CAMEL-25564)
   
   apache/camel#27716 makes camel-telegram register the webhook with a secret token (the `secret_token` parameter of
   `setWebhook`), and verify the `X-Telegram-Bot-Api-Secret-Token` header of webhook requests: a request without it gets
   HTTP 403. The telegram integration test needs three changes:
   
   - the webhook route sets `webhook-secret-token`, from the new `webhook-secret-token` property
     (`TELEGRAM_WEBHOOK_SECRET_TOKEN`, default `fake-secret-token`);
   - `TelegramTest#testWebhookEndpoint` sends the same value in the header;
   - the WireMock mapping of `setWebhook` expects the `secret_token` parameter, as it matches the whole query. Without
     this, the registration at startup would get no match, and the webhook route would fail to start.
   
   This stays a draft until apache/camel#27716 is merged and a Camel snapshot with the new option is published. Until
   then the route cannot start, as `webhook-secret-token` is not a known option of the telegram endpoint.
   
   ## Tests
   
   Not run locally: this branch builds camel-quarkus 4.0.0-SNAPSHOT, which I did not have built. CI will check it once
   the Camel snapshot is available. The same change is verified in camel-telegram (apache/camel#27716) and in
   camel-spring-boot (apache/camel-spring-boot#2029).
   
   _Claude Code on behalf of oscerd_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-25564: Telegram - send the webhook secret token in the webhook test [camel-quarkus]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #9317:
URL: https://github.com/apache/camel-quarkus/pull/9317#issuecomment-6187383522

   Status: apache/camel#27716 is merged, and the Camel 4.23.0-SNAPSHOT published on 2026-10-14 has the new options, so the telegram integration test now compiles.
   
   The `initial-mvn-install` job still fails, but only at "Fail if there are uncommitted changes", and on files this PR does not touch: the `wasm` extension docs (`wasm.yml`, `wasm.adoc`) and the flattened BOM poms, which the latest snapshot regenerates. That is `camel-main` needing its next regen. I'm keeping this a draft until a run after that regen is green, so that `TelegramTest#testWebhookEndpoint` actually runs.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org