You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/24 01:36:14 UTC

[GitHub] [incubator-pinot] ianvkoeppe commented on a change in pull request #5745: Allow serving of offline segments immediately/inclusively.

ianvkoeppe commented on a change in pull request #5745:
URL: https://github.com/apache/incubator-pinot/pull/5745#discussion_r459814064



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -140,6 +141,8 @@ public BaseBrokerRequestHandler(PinotConfiguration config, RoutingManager routin
 
     _enableQueryLimitOverride = _config.getProperty(Broker.CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE, false);
 
+    _serveOfflineSegmentsImmediately = _config.getProperty(Broker.CONFIG_OF_BROKER_SERVE_OFFLINE_SEGMENTS_IMMEDIATELY, false);

Review comment:
       @kishoreg, that makes sense. Any recommendation for which subconfig of table config? There are routing configs, segment configs, etc. I'm not sure the right one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org