You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwhisk.apache.org by ra...@apache.org on 2020/04/14 15:42:33 UTC

[openwhisk] branch master updated: Fix typos in comments.

This is an automated email from the ASF dual-hosted git repository.

rabbah pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwhisk.git


The following commit(s) were added to refs/heads/master by this push:
     new ae2bd3a  Fix typos in comments.
ae2bd3a is described below

commit ae2bd3a6195257847dbe45d9d4b5e5e6d2fbf6f5
Author: Rodric Rabbah <ro...@gmail.com>
AuthorDate: Mon Apr 13 18:35:19 2020 -0400

    Fix typos in comments.
---
 .../org/apache/openwhisk/core/controller/WebActions.scala      | 10 +++++-----
 .../openwhisk/core/controller/test/WebActionsApiTests.scala    |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala b/core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala
index 182881f..a62a5cb 100644
--- a/core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala
+++ b/core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala
@@ -751,16 +751,16 @@ trait WhiskWebActionsApi
   }
 
   /**
-   * Check if "require-whisk-auth" authentication is needed, and if so, authenticate the request
-   * NOTE: Only number or string JSON "require-whisk-auth" annotation values are supported
+   * Checks if "require-whisk-auth" authentication is needed, and if so, authenticate the request.
+   * NOTE: Only number or string JSON "require-whisk-auth" annotation values are supported.
    *
    * @param annotations - web action annotations
    * @param reqHeaders  - web action invocation request headers
    * @return Option[Boolean]
-   *         None if annotations does not include require-whisk-auth (i.e. auth test not needed)
-   *         Some(true) if annotations includes require-whisk-auth and it's value matches the request header `X-Require-Whisk-Auth` value
+   *         None if annotations does not include require-whisk-auth (i.e., auth test not needed)
+   *         Some(true) if annotations includes require-whisk-auth and its value matches the request header `X-Require-Whisk-Auth` value
    *         Some(false) if annotations includes require-whisk-auth and the request does not include the header `X-Require-Whisk-Auth`
-   *         Some(false) if annotations includes require-whisk-auth and it's value deos not match the request header `X-Require-Whisk-Auth` value
+   *         Some(false) if annotations includes require-whisk-auth and its value does not match the request header `X-Require-Whisk-Auth` value
    */
   private def requiredWhiskAuthSuccessful(annotations: Parameters, reqHeaders: Seq[HttpHeader]): Option[Boolean] = {
     annotations
diff --git a/tests/src/test/scala/org/apache/openwhisk/core/controller/test/WebActionsApiTests.scala b/tests/src/test/scala/org/apache/openwhisk/core/controller/test/WebActionsApiTests.scala
index c580de3..e91b5a1 100644
--- a/tests/src/test/scala/org/apache/openwhisk/core/controller/test/WebActionsApiTests.scala
+++ b/tests/src/test/scala/org/apache/openwhisk/core/controller/test/WebActionsApiTests.scala
@@ -135,7 +135,7 @@ trait WebActionsApiBaseTests extends ControllerTestCommon with BeforeAndAfterEac
   var failThrottleForSubject: Option[Subject] = None // toggle to cause throttle to fail for subject
   var failCheckEntitlement = false // toggle to cause entitlement to fail
   var actionResult: Option[JsObject] = None
-  var requireAuthenticationAsBoolean = true // toggle value set in require-whisk-auth annotation (true or  requireAuthenticationKey)
+  var requireAuthenticationAsBoolean = true // toggle value set in require-whisk-auth annotation (true or requireAuthenticationKey)
   var testParametersInInvokeAction = true // toggle to test parameter in invokeAction
   var requireAuthenticationKey = "example-web-action-api-key"
   var invocationCount = 0