You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/09 20:20:16 UTC
Review Request 37275: Generate make batch file to build project in
windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
-----------------------------------------------------------
Review request for mesos and Alex Clemmer.
Repository: mesos
Description
-------
Generate make batch file to build project in windows.
Diffs
-----
CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/37275/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 37275: [3/3]Generate make batch file to build
project in windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review94693
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37272, 37273, 37275]
All tests passed.
- Mesos ReviewBot
On Aug. 9, 2015, 6:21 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 6:21 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate make batch file to build project in windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/37275/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37275: [2/2]Generate make batch file to build
project in windows.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 31, 2015, 6:50 p.m., Joseph Wu wrote:
> > cmake/MesosConfigure.cmake, line 125
> > <https://reviews.apache.org/r/37275/diff/2/?file=1036055#file1036055line125>
> >
> > Why do you need this? (If you do need it, comment why.)
> >
> > It doesn't look like the inputs have any semicolons.
Because cmake convert list [a, b, c] to string "a;b;c". When we write a string to file, need replace ";" to " " first.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97113
-----------------------------------------------------------
On Sept. 4, 2015, 4:24 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 4:24 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate make batch file to build project in windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/37275/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37275: [2/2]Generate make batch file to build
project in windows.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97113
-----------------------------------------------------------
cmake/MesosConfigure.cmake (line 76)
<https://reviews.apache.org/r/37275/#comment152864>
This comment doesn't need to change. If anything, you could add an extra line, like:
```
Your version of MSVC is ${MSVC_VERSION}.
```
Or:
```
Mesos does not support compiling on MSVC version ${MSVC_VERSION}, which is earlier than version 1900.
```
cmake/MesosConfigure.cmake (line 125)
<https://reviews.apache.org/r/37275/#comment152883>
Why do you need this? (If you do need it, comment why.)
It doesn't look like the inputs have any semicolons.
- Joseph Wu
On Aug. 30, 2015, 6:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 6:42 a.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate make batch file to build project in windows.
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
> cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
>
> Diff: https://reviews.apache.org/r/37275/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37275: [2/2]Generate make batch file to build
project in windows.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
-----------------------------------------------------------
(Updated Aug. 30, 2015, 1:42 p.m.)
Review request for mesos and Alex Clemmer.
Summary (updated)
-----------------
[2/2]Generate make batch file to build project in windows.
Repository: mesos
Description
-------
Generate make batch file to build project in windows.
Diffs
-----
CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/37275/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 37275: [3/3]Generate make batch file to build
project in windows.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 9:52 a.m.)
Review request for mesos and Alex Clemmer.
Changes
-------
Remove unnessary params
Repository: mesos
Description
-------
Generate make batch file to build project in windows.
Diffs (updated)
-----
CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/37275/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 37275: [3/3]Generate make batch file to build
project in windows.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
-----------------------------------------------------------
(Updated Aug. 9, 2015, 6:21 p.m.)
Review request for mesos and Alex Clemmer.
Summary (updated)
-----------------
[3/3]Generate make batch file to build project in windows.
Repository: mesos
Description
-------
Generate make batch file to build project in windows.
Diffs
-----
CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3
cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8
Diff: https://reviews.apache.org/r/37275/diff/
Testing
-------
Thanks,
haosdent huang