You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Hiteshgautam01 <gi...@git.apache.org> on 2018/07/10 18:54:17 UTC

[GitHub] incubator-taverna-mobile pull request #91: WorkflowDetailFragment Improvemen...

GitHub user Hiteshgautam01 opened a pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/91

    WorkflowDetailFragment Improvements

    Please make sure these boxes are checked before submitting your pull request - thanks!
    
    - [ ] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
    
    - [ ] Run the checks with `./gradlew check` to make sure you didn't break anything
    
    - [ ] If you have multiple commits please combine them into one commit by squashing them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile ScrollImprovements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-taverna-mobile/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit 366fcd7c3dc10a8590fb82851ddc1454da871e84
Author: Hitesh Gautam <ga...@...>
Date:   2018-07-10T18:52:50Z

    WorkflowDetailFragment Improvements

----


---

[GitHub] incubator-taverna-mobile pull request #91: WorkflowDetailFragment Improvemen...

Posted by sagar15795 <gi...@git.apache.org>.
Github user sagar15795 commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/91#discussion_r201679574
  
    --- Diff: app/src/main/res/layout/fragment_detail_workflow.xml ---
    @@ -102,7 +111,8 @@
                                 android:layout_width="wrap_content"
                                 android:layout_height="wrap_content"
                                 android:textColor="@android:color/black"
    -                            android:textSize="@dimen/tv_uploader_name_text_size"/>
    +                            android:textSize="@dimen/tv_uploader_name_text_size"
    +                            android:layout_marginTop="4sp"/>
    --- End diff --
    
    use `4dp` in place of `4sp`. and also move it to `dimens.xml` 


---

[GitHub] incubator-taverna-mobile pull request #91: WorkflowDetailFragment Improvemen...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-taverna-mobile/pull/91


---