You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Swapnil M Mane (JIRA)" <ji...@apache.org> on 2016/04/16 12:53:25 UTC

[jira] [Created] (OFBIZ-7010) Shipping method is shown on all Promo Conditions when any single condition includes Shipping Method

Swapnil M Mane created OFBIZ-7010:
-------------------------------------

             Summary: Shipping method is shown on all Promo Conditions when any single condition includes Shipping Method
                 Key: OFBIZ-7010
                 URL: https://issues.apache.org/jira/browse/OFBIZ-7010
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: Release Branch 15.12, 14.12.01, Upcoming Branch, 13.07.04
            Reporter: Swapnil M Mane
            Priority: Minor


If we create any Promo condition by selecting any Shipping Method.

Now for all the conditions, we create after this, automatically includes the previously selected Shipping Method.
___________________________________________________________

Reason:

Basically, it's a UI issue, the Promo Condition created in the database are correct.

In EditProductPromoRules.ftl, we assign 'carrierShippingMethod' and 'carrierParty' in iteration with the Promotion condition 'productPromoConds'

{{code}}
<#list productPromoConds as productPromoCond>
...
   <#assign carrierShippingMethod = productPromoCond.otherValue!>
...
{{code}}
___________________________________________________________

Solution:

Before assigning the 'carrierShippingMethod' and 'carrierParty' from Promo Condition, reset the previously set value.
for e.g.
<#assign carrierShippingMethod = ""/>
<#if otherValue?has_content && otherValue.contains("@")>
  <#assign carrierShippingMethod = productPromoCond.otherValue!>
</#if>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)