You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ke...@apache.org on 2020/08/09 08:21:53 UTC
[skywalking] branch master updated: Remove Buffer redundant
strategy judgment code. (#5277)
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new b8e5ff5 Remove Buffer redundant strategy judgment code. (#5277)
b8e5ff5 is described below
commit b8e5ff516c71a7b6da970deaf4cfdcf852dc6d49
Author: 李文广 <li...@163.com>
AuthorDate: Sun Aug 9 16:21:36 2020 +0800
Remove Buffer redundant strategy judgment code. (#5277)
---
.../skywalking/apm/commons/datacarrier/buffer/Buffer.java | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Buffer.java b/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Buffer.java
index d1f9217..b2f97c3 100644
--- a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Buffer.java
+++ b/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Buffer.java
@@ -35,22 +35,16 @@ public class Buffer<T> implements QueueBuffer<T> {
index = new AtomicRangeInteger(0, bufferSize);
}
+ @Override
public void setStrategy(BufferStrategy strategy) {
this.strategy = strategy;
}
+ @Override
public boolean save(T data) {
int i = index.getAndIncrement();
if (buffer[i] != null) {
switch (strategy) {
- case BLOCKING:
- while (buffer[i] != null) {
- try {
- Thread.sleep(1L);
- } catch (InterruptedException e) {
- }
- }
- break;
case IF_POSSIBLE:
return false;
default:
@@ -60,10 +54,12 @@ public class Buffer<T> implements QueueBuffer<T> {
return true;
}
+ @Override
public int getBufferSize() {
return buffer.length;
}
+ @Override
public void obtain(List<T> consumeList) {
this.obtain(consumeList, 0, buffer.length);
}