You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Odd Vinje (JIRA)" <ji...@apache.org> on 2011/02/23 13:30:38 UTC

[jira] Created: (FELIX-2856) Goal bundleall breaks for optional dependencies with a scope.

Goal bundleall breaks for optional dependencies with a scope. 
--------------------------------------------------------------

                 Key: FELIX-2856
                 URL: https://issues.apache.org/jira/browse/FELIX-2856
             Project: Felix
          Issue Type: Improvement
          Components: Maven Bundle Plugin
    Affects Versions: maven-bundle-plugin-2.3.4
            Reporter: Odd Vinje


A lot of code changes have been commited to bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java, but relevant changes have not been refelected in BundleAllPlugin.java. Maybe the two classes need delegation/refactoring. 

Example: 
Goal bundleall now breaks for optional dependencies with a scope.  This is handled in bundle goal: 

            if( artifact.isOptional() ) {
                String id = artifact.toString();
                if( artifact.getScope()!=null ) {
                    // strip the scope...
                    id = id.replaceFirst(":[^:]*$", "");
                }
                optionalArtifactIds.add(id);
            }

but not in bundleall...

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (FELIX-2856) Goal bundleall breaks for optional dependencies with a scope.

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch closed FELIX-2856.
-----------------------------------

    Resolution: Won't Fix

The "bundleall" goal is going to be deprecated, so closing this issue as won't fix. Instead new features/goals will be added to solve common use-cases such as creating mega-bundles, etc.

> Goal bundleall breaks for optional dependencies with a scope. 
> --------------------------------------------------------------
>
>                 Key: FELIX-2856
>                 URL: https://issues.apache.org/jira/browse/FELIX-2856
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.3.4
>            Reporter: Odd Vinje
>              Labels: bundle, bundleall
>
> A lot of code changes have been commited to bundleplugin/src/main/java/org/apache/felix/bundleplugin/BundlePlugin.java, but relevant changes have not been refelected in BundleAllPlugin.java. Maybe the two classes need delegation/refactoring. 
> Example: 
> Goal bundleall now breaks for optional dependencies with a scope.  This is handled in bundle goal: 
>             if( artifact.isOptional() ) {
>                 String id = artifact.toString();
>                 if( artifact.getScope()!=null ) {
>                     // strip the scope...
>                     id = id.replaceFirst(":[^:]*$", "");
>                 }
>                 optionalArtifactIds.add(id);
>             }
> but not in bundleall...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira