You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Arthur Naseef (JIRA)" <ji...@apache.org> on 2010/12/18 00:52:01 UTC
[jira] Created: (AMQ-3097) add Function calls to selectors
add Function calls to selectors
-------------------------------
Key: AMQ-3097
URL: https://issues.apache.org/jira/browse/AMQ-3097
Project: ActiveMQ
Issue Type: New Feature
Components: Selector
Affects Versions: 5.4.2
Environment: n/a
Reporter: Arthur Naseef
Priority: Minor
As described in the Nabble thread, "custom selector / filter for messages", I have implemented message call support in selectors, together with a few initial functions and the ability to register new functions without modifying the core.
Attached is a patch that implements this feature.
There are no unit tests currently implemented, but I can provide them in the near future if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AMQ-3097) add Function calls to selectors
Posted by "Arthur Naseef (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arthur Naseef updated AMQ-3097:
-------------------------------
Attachment: selectorFunctions.patch
Patch that adds function call syntax to the selector grammar, function call expressions, and a few initial functions.
> add Function calls to selectors
> -------------------------------
>
> Key: AMQ-3097
> URL: https://issues.apache.org/jira/browse/AMQ-3097
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Selector
> Affects Versions: 5.4.2
> Environment: n/a
> Reporter: Arthur Naseef
> Priority: Minor
> Attachments: selectorFunctions.patch
>
>
> As described in the Nabble thread, "custom selector / filter for messages", I have implemented message call support in selectors, together with a few initial functions and the ability to register new functions without modifying the core.
> Attached is a patch that implements this feature.
> There are no unit tests currently implemented, but I can provide them in the near future if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (AMQ-3097) add Function calls to selectors
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439555#comment-13439555 ]
Gary Tully commented on AMQ-3097:
---------------------------------
we need some unit tests to validate this new feature. There is no point adding features without tests because there will be nothing to protect the feature into the future.
*Unit tests are a must have*
> add Function calls to selectors
> -------------------------------
>
> Key: AMQ-3097
> URL: https://issues.apache.org/jira/browse/AMQ-3097
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Selector
> Affects Versions: 5.4.2
> Environment: n/a
> Reporter: Arthur Naseef
> Priority: Minor
> Attachments: selectorFunctions.patch
>
>
> As described in the Nabble thread, "custom selector / filter for messages", I have implemented message call support in selectors, together with a few initial functions and the ability to register new functions without modifying the core.
> Attached is a patch that implements this feature.
> There are no unit tests currently implemented, but I can provide them in the near future if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3097) add Function calls to selectors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446728#comment-13446728 ]
Claus Ibsen commented on AMQ-3097:
----------------------------------
Just from a JMS spec point of view, is it allowed to add support for extensions such as function calls?
Despite it could be a nice feature.
> add Function calls to selectors
> -------------------------------
>
> Key: AMQ-3097
> URL: https://issues.apache.org/jira/browse/AMQ-3097
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Selector
> Affects Versions: 5.4.2
> Environment: n/a
> Reporter: Arthur Naseef
> Priority: Minor
> Attachments: selectorFunctions.patch
>
>
> As described in the Nabble thread, "custom selector / filter for messages", I have implemented message call support in selectors, together with a few initial functions and the ability to register new functions without modifying the core.
> Attached is a patch that implements this feature.
> There are no unit tests currently implemented, but I can provide them in the near future if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3097) add Function calls to selectors
Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447184#comment-13447184 ]
Gary Tully commented on AMQ-3097:
---------------------------------
the spec does not impose any restrictions, so extending to support functions is fine from that perspective. It is a sensible "push of the envelope"
> add Function calls to selectors
> -------------------------------
>
> Key: AMQ-3097
> URL: https://issues.apache.org/jira/browse/AMQ-3097
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Selector
> Affects Versions: 5.4.2
> Environment: n/a
> Reporter: Arthur Naseef
> Priority: Minor
> Attachments: selectorFunctions.patch
>
>
> As described in the Nabble thread, "custom selector / filter for messages", I have implemented message call support in selectors, together with a few initial functions and the ability to register new functions without modifying the core.
> Attached is a patch that implements this feature.
> There are no unit tests currently implemented, but I can provide them in the near future if needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira