You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/12/13 02:40:52 UTC

[GitHub] [dubbo-go] justxuewei commented on a diff in pull request #2139: 3.0 notify sleep

justxuewei commented on code in PR #2139:
URL: https://github.com/apache/dubbo-go/pull/2139#discussion_r1046601426


##########
registry/nacos/registry.go:
##########
@@ -207,6 +209,27 @@ func (nr *nacosRegistry) UnSubscribe(url *common.URL, _ registry.NotifyListener)
 	return nil
 }
 
+// LoadSubscribeInstance load subscribe instance
+func (nr *nacosRegistry) LoadSubscribeInstance(url *common.URL, notify registry.NotifyListener) error {

Review Comment:
   The name should be plural: `LoadSubscribeInstances`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org