You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 15:23:44 UTC

[GitHub] [apisix] Miss-you opened a new issue #2788: bug: In function is_empty_yaml_line, 'string.find' plain mode is not recommended, and re.find is better.

Miss-you opened a new issue #2788:
URL: https://github.com/apache/apisix/issues/2788


   ### Issue description
   
   ```
   local function is_empty_yaml_line(line)
       return line == '' or string.find(line, '^%s*$') or
              string.find(line, '^%s*#')
   end
   ```
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):
   * OS:
   
   ### Minimal test code / Steps to reproduce the issue
   1.
   2.
   3.
   
   ### What's the actual result? (including assertion message & call stack if applicable)
   
   
   
   ### What's the expected result?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] idbeta commented on issue #2788: perf: In function is_empty_yaml_line, 'string.find' plain mode is not recommended, and re.find is better.

Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #2788:
URL: https://github.com/apache/apisix/issues/2788#issuecomment-730265422


   Is there test data to prove it is better?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis closed issue #2788: perf: In function is_empty_yaml_line, 'string.find' plain mode is not recommended, and re.find is better.

Posted by GitBox <gi...@apache.org>.
membphis closed issue #2788:
URL: https://github.com/apache/apisix/issues/2788


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tokers commented on issue #2788: perf: In function is_empty_yaml_line, 'string.find' plain mode is not recommended, and re.find is better.

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #2788:
URL: https://github.com/apache/apisix/issues/2788#issuecomment-730801052


   Currently `bin/apisix` is interpreted by the Lua.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org