You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2021/07/21 04:23:55 UTC

[GitHub] [royale-asjs] estanglerbm opened a new pull request #1134: Fix exception in SWF target with recent changes in ContentView.

estanglerbm opened a new pull request #1134:
URL: https://github.com/apache/royale-asjs/pull/1134


   Fixes issue in SWF target caused by PR #1041.
   
   Basically, any Container with an addElement() that proxies to contentView.addElement() needs to check that the child is not the contentView.  This comes about through ContainerView.  (If it is addElement(contentView), then it needs to call super.addElement() instead of proxying the call.)
   
   [Legacy was that addElement(contentView) happened only on JS side, and the addElement() proxying was usually only on the SWF side (except in SkinnableContainer), so they didn't interact.  Recent changes made addElement(contentView) happen on the SWF side, too, so now they interacted.]
   
   ADDED CHECK
   
   frameworks\projects\Basic\src\main\royale\org\apache\royale\core\ContainerBase.as
   frameworks\projects\MXRoyale\src\main\royale\mx\core\Container.as
   frameworks\projects\Jewel\src\main\royale\org\apache\royale\jewel\supportClasses\container\ContainerBase.as
   
   CHECK NOT NEEDED
   
   frameworks\projects\SparkRoyale\src\main\royale\spark\components\SkinnableContainer.as
   	- Already has the check.
   
   frameworks\projects\Basic\src\main\royale\org\apache\royale\svg\GraphicContainer.as
   	- Doesn't have contentView.
   
   frameworks\projects\Core\src\main\royale\org\apache\royale\core\ContainerBaseStrandChildren.as
   	- Doesn't have contentView.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] yishayw merged pull request #1134: Fix exception in SWF target with recent changes in ContentView.

Posted by GitBox <gi...@apache.org>.
yishayw merged pull request #1134:
URL: https://github.com/apache/royale-asjs/pull/1134


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] estanglerbm commented on pull request #1134: Fix exception in SWF target with recent changes in ContentView.

Posted by GitBox <gi...@apache.org>.
estanglerbm commented on pull request #1134:
URL: https://github.com/apache/royale-asjs/pull/1134#issuecomment-884065831


   Closes #1051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org