You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "astefanutti (via GitHub)" <gi...@apache.org> on 2023/03/01 12:06:11 UTC
[GitHub] [camel-k] astefanutti opened a new pull request, #4088: feat: Add path-based Ingress options to the ingress trait
astefanutti opened a new pull request, #4088:
URL: https://github.com/apache/camel-k/pull/4088
This PR adds a set of new options to the _ingress_ trait, so it's possible to configure "path-based" [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/).
As ingresses can traditionally be configured based on annotations, e.g. with the [NGINX ingress controller](https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/nginx-configuration/annotations.md), this PR coincidentally adds support to set trait options of type map from the CLI, e.g.:
```
$ kamel run \
-t ingress.annotations.'nginx.ingress.kubernetes.io/use-regex'=true \
-t ingress.annotations.'nginx.ingress.kubernetes.io/rewrite-target'='/$2' \
-t ingress.path='/base_path(/|$)(.*)'
```
**Release Note**
```release-note
feat(trait): Add path-based Ingress options to ingress trait
feat(cli): Support setting maps in traits API
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #4088: feat: Add path-based Ingress options to the ingress trait
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #4088:
URL: https://github.com/apache/camel-k/pull/4088#issuecomment-1450040093
Just a reminder, this will go in 2.x, if this is something we want for 1.x, we need to backport on 1.12.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #4088: feat: Add path-based Ingress options to the ingress trait
Posted by "astefanutti (via GitHub)" <gi...@apache.org>.
astefanutti merged PR #4088:
URL: https://github.com/apache/camel-k/pull/4088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #4088: feat: Add path-based Ingress options to the ingress trait
Posted by "astefanutti (via GitHub)" <gi...@apache.org>.
astefanutti commented on PR #4088:
URL: https://github.com/apache/camel-k/pull/4088#issuecomment-1451440419
@oscerd thanks for the reminder. I've created #4090 that targets the `release-1.12.x` branch, which I assumed is the current 1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org