You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Claude Brisson (JIRA)" <ve...@apache.org> on 2006/11/02 20:49:16 UTC
[jira] Created: (VELTOOLS-67) Patch implementing path-scoped tools
Patch implementing path-scoped tools
------------------------------------
Key: VELTOOLS-67
URL: http://issues.apache.org/jira/browse/VELTOOLS-67
Project: VelocityTools
Issue Type: New Feature
Components: VelocityView
Affects Versions: 1.3
Environment: all
Reporter: Claude Brisson
Priority: Minor
Attachments: path-scopes.patch
This patch adds two new scopes:
<scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
<scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12449806 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
Doh. You're totally right on the session tool implementation. It doesn't make much sense to just do it for the session-creating request. I didn't think that through, just saw the opportunity to apply the path restriction there and took it. Maybe we should just support this for request scoped tools for now. Let me think about it...
And thanks for the docs patch!!
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Fix For: 1.3
>
> Attachments: docs.patch, path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12448819 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
Ok, here's some pushback...
i'm not sure i like putting the path restrictions down as a scope.
a) it causes the value into ServletToolInfo.setScope() to not match getScope()
b) what if you want to restrict a session/application oriented tool to certain paths?
what do you think about making the path a totally separate property of ServletToolInfo? i know that makes things more complicated, especially in ServletToolboxManager.getToolbox() if we want to path-restrict session/application tools. Maybe to start things off we could have the path restriction as a separate property and add a fourth "request-path" scope option. Then we don't get a set/getScope mismatch and still limit path restriction to request scope (simplifying getToolbox()) but leave open the possibility of allowing session or application tools to be path-restricted.
thoughts anyone (esp Claude)?
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12448905 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
Another question...
Why insist that wildcard paths end with '/' ? What if i wanted to enable a tool for all /view* (e.g. /viewFoo) but not /edit* (e.g. /editFoo)?
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELTOOLS-67) Patch implementing path-scoped tools
Posted by "Claude Brisson (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=all ]
Claude Brisson updated VELTOOLS-67:
-----------------------------------
Attachment: docs.patch
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Fix For: 1.3
>
> Attachments: docs.patch, path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12449822 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
http://svn.apache.org/viewvc?view=rev&rev=475017
Documentation patch has been adapted to xdoc and applied. Thanks!
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Fix For: 1.3
>
> Attachments: docs.patch, path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Claude Brisson (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12448927 ]
Claude Brisson commented on VELTOOLS-67:
----------------------------------------
> what do you think about making the path a totally separate property of ServletToolInfo?
+1 for a separate "request-path" parameter.
That's obviously a cleaner implementation than mine.
> Why insist that wildcard paths end with '/' ? What if i wanted to enable a tool for all /view* (e.g. /viewFoo) but not /edit* (e.g. /editFoo)?
It was to somehow mimic the behaviour of the "/*" url-pattern wilcard behaviour in a webapp deployment descriptor, but you are right, we don't need to inforce it.
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELTOOLS-67) Patch implementing path-scoped tools
Posted by "Claude Brisson (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=all ]
Claude Brisson updated VELTOOLS-67:
-----------------------------------
Attachment: path-scopes.patch
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Attachments: path-scopes.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12449816 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
http://svn.apache.org/viewvc?view=rev&rev=475015
Ok, path restrictions are now limited to request-scoped tools. Thanks, Claude, for setting me straight! :)
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Fix For: 1.3
>
> Attachments: docs.patch, path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Claude Brisson (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12449797 ]
Claude Brisson commented on VELTOOLS-67:
----------------------------------------
Clean implementation.
Two things, though :
1. Maybe it's me, but I don't understand at all where you manage to contextualize session scoped tools that are visible in a request. That is, I've got the feeling that visible tools are determinated only using the request that creates the session. I thought this could only be done by putting session scoped tools in a subclass of Map filtering the getter according to the request URI.
2. My addition to the docs was lost with the first patch, so I resubmit it appart (I should have done that at first time).
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Fix For: 1.3
>
> Attachments: path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12449034 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
Looks good. i have a few refinements, but i'll try and get this in on Monday.
As for supporting this with session/application scoped tools, it wouldn't work well to do it in ChainedContext, since the ToolInfo isn't in really in view there. i'd rather keep the restriction in front of tool init rather than after. i think there may be ways to do this in the manager without much pain, but we may need to wait until 2.x.
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELTOOLS-67) Patch implementing path-scoped tools
Posted by "Claude Brisson (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=all ]
Claude Brisson updated VELTOOLS-67:
-----------------------------------
Attachment: request-path.patch
A new candidate patch which implements the request-path element.
I was thinking on the way to implement this feature for session and application tools, and I think that the best option is leave the tools in the toolbox and implement a filter in the ChainedContext getter.
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Assigned: (VELTOOLS-67) Patch implementing path-scoped tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=all ]
Nathan Bubna reassigned VELTOOLS-67:
------------------------------------
Assignee: Nathan Bubna
Cool. I've long liked this idea since it was brought up ages ago. I do have some minor quibbles about implementation, but i want to try and get this into 1.3. I'll gather my thoughts and get your feedback before i check it all in...
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org
[jira] Resolved: (VELTOOLS-67) Patch implementing path-scoped tools
Posted by "Nathan Bubna (JIRA)" <ve...@apache.org>.
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=all ]
Nathan Bubna resolved VELTOOLS-67.
----------------------------------
Fix Version/s: 1.3
Resolution: Fixed
Implemented in revision 474952.
Ok, it's in. I managed to make it easily support path-restrictions for session scope tools and to reject path-restrictions on application scoped tools for the time being. Let me know what you think and of course how it works for you!
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Fix For: 1.3
>
> Attachments: path-scopes.patch, request-path.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org