You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/26 03:40:13 UTC
[GitHub] [flink] xintongsong commented on a change in pull request #8841:
[FLINK-12765][coordinator] Bookkeeping of available resources of allocated
slots in SlotPool
xintongsong commented on a change in pull request #8841: [FLINK-12765][coordinator] Bookkeeping of available resources of allocated slots in SlotPool
URL: https://github.com/apache/flink/pull/8841#discussion_r297471061
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
##########
@@ -316,6 +331,9 @@ public boolean contains(AbstractID groupId) {
// true if we are currently releasing our children
private boolean releasingChildren;
+ // the total requested by all the descendants.
+ private ResourceProfile requestedResources;
Review comment:
I think this is a little confusing. Do you mean the resource requested by tasks that are already assigned into the slot? May be use "occupied" or "allocated" to avoid ambiguity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services