You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Mandalka <gi...@git.apache.org> on 2018/01/14 02:27:23 UTC
[GitHub] lucene-solr pull request #305: SOLR-11853: Make check for used tool "service...
GitHub user Mandalka opened a pull request:
https://github.com/apache/lucene-solr/pull/305
SOLR-11853: Make check for used tool "service" compatible with SuSE Linux
On current SuSE Linux releases like SLES or OpenSuSE the Solr installer stops with the error message "Script requires the 'service' command".
This happens because before installation the installer checks if the used command "service" exists by its option "service --version".
The command line option "--version" doesn't exist for "service" on current SuSE Linux stable releases.
Since the command "service" is there and has an option "--help", this option can be used as additional fallback.
So in the pull request i extended the check with "service --help" as second check / fallback before printing this error and exiting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mandalka/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #305
----
commit 0aa573740b55027192440fc5997a93945ca9b9b3
Author: Markus Mandalka <gi...@...>
Date: 2018-01-14T02:14:47Z
Make check for used tool 'service' compatible with SuSE Linux like OpenSuse or SLES
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...
Posted by janhoy <gi...@git.apache.org>.
Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/305
If `--help` works on all platforms, why not just switch? I checked with docker in ubuntu, centos and they both support --help
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...
Posted by hal869 <gi...@git.apache.org>.
Github user hal869 commented on the issue:
https://github.com/apache/lucene-solr/pull/305
Can this be merged/released?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...
Posted by Mandalka <gi...@git.apache.org>.
Github user Mandalka commented on the issue:
https://github.com/apache/lucene-solr/pull/305
I was not sure if there might be platforms without service --help and did not want maybe to break something on other unknown platforms (i am familar only with Debian and Ubuntu) so i added the fallback, but if it works by switch to help, i can prepare another PR, if someone can merge it (or if not changed directly).
Another problem is, that there is no group solr by the user adding command on SuSE and the group is needed by the service config reading, but that was solveable without patching the installer by manually adding the group. Could prepare another PR for that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #305: SOLR-11853: Make check for used tool "service...
Posted by Mandalka <gi...@git.apache.org>.
Github user Mandalka closed the pull request at:
https://github.com/apache/lucene-solr/pull/305
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...
Posted by Mandalka <gi...@git.apache.org>.
Github user Mandalka commented on the issue:
https://github.com/apache/lucene-solr/pull/305
For future OpenSuSE releases the main issue / need of patch (rest of failing steps can be done after installation by adding group and rights) is solved by https://github.com/openSUSE/aaa_base/pull/53 which was merged to master, but maybe because of very long release live times not for former/current SLES.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #305: SOLR-11853: Make check for used tool "service" compa...
Posted by Mandalka <gi...@git.apache.org>.
Github user Mandalka commented on the issue:
https://github.com/apache/lucene-solr/pull/305
This PR was solved by https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a1c6e64 so rest like missing group solr and rights of /etc/default/$SOLR_SERVICE.in.sh and setting Solr users shell from /bin/false to bash can be set after installation without patching original Solr files.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org