You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/09/01 07:19:59 UTC
[PR] Use storage-aware schema keys for configured single tables [shardingsphere]
menghaoranss opened a new pull request, #39677:
URL: https://github.com/apache/shardingsphere/pull/39677
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use storage-aware schema keys for configured single tables [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39677:
URL: https://github.com/apache/shardingsphere/pull/39677#issuecomment-5491577840
```markdown
### Correction
- **Previous Finding:** The `DataNode` factory parameter order was inconsistent with the existing constructor.
- **Current Status:** Withdrawn
- **Reason:** Commit `602017ca6ac731ed4a7579234c561c9a454f8fba` consistently reorders the factory, private delegation path, Javadoc, tests, and production caller.
### Result
**Review Result: Mergeable**
No blocking code-correctness issues remain at the current head.
### Evidence
- [`DataNode.java:71-98`](https://github.com/apache/shardingsphere/blob/602017ca6ac731ed4a7579234c561c9a454f8fba/infra/common/src/main/java/org/apache/shardingsphere/infra/datanode/DataNode.java#L71-L98) now consistently orders the schema/database-name argument before the database type.
- The storage-aware schema key is propagated consistently through `SingleTableDataNodeLoader`.
- Focused verification passed: 48 `DataNodeTest` cases and 22 `SingleTableDataNodeLoaderTest` cases.
- Scoped Spotless and Checkstyle verification passed with no violations.
### Coverage
- Reviewed public PR #39677 at head `602017ca6ac731ed4a7579234c561c9a454f8fba`.
- All four authoritative changed files matched the local triple-dot inventory.
- Reviewed the latest three-file corrective delta and reconverged across the complete PR.
- Covered resolved-schema `DataNode` construction and storage-aware configured-single-table matching.
- Completed root-cause, blast-radius/contracts, tests/runtime/operations, and convergence passes.
- No unresolved evidence gaps or local-only changes were included.
- This is a code-scope result only; CI was not reviewed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use storage-aware schema keys for configured single tables [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39677:
URL: https://github.com/apache/shardingsphere/pull/39677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org