You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sameeragarwal <gi...@git.apache.org> on 2017/05/25 06:59:02 UTC

[GitHub] spark pull request #17343: [SPARK-20014] Optimize mergeSpillsWithFileStream ...

Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17343#discussion_r118428258
  
    --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriter.java ---
    @@ -98,6 +99,18 @@
        */
       private boolean stopping = false;
     
    +  private class CloseAndFlushShieldOutputStream extends CloseShieldOutputStream {
    +
    +    public CloseAndFlushShieldOutputStream(OutputStream outputStream) {
    --- End diff --
    
    This needn't be public


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org