You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2023/06/12 23:53:21 UTC

[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #769: refactor(c/driver/postgresql): Use AdbcGetInfoData structure

WillAyd commented on code in PR #769:
URL: https://github.com/apache/arrow-adbc/pull/769#discussion_r1227349997


##########
c/validation/adbc_validation_util.h:
##########
@@ -197,6 +198,22 @@ struct StreamReader {
   }
 };
 
+/// \brief Read an AdbcGetInfoData struct with RAII safety
+struct GetInfoReader {
+  explicit GetInfoReader(struct ArrowArrayView* array_view) : array_view_(array_view) {

Review Comment:
   Probably need to do something here to better tie in the lifetime of the `array_view`, though I wasn't sure if that was worth doing as a separate class like this or maybe integrating into the existing `StreamReader` class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org