You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "yjhjstz (via GitHub)" <gi...@apache.org> on 2026/08/20 16:41:46 UTC

[PR] [ORCA] Narrow CTE Producer columns in CXformGbAggWithMDQA2Join [cloudberry]

yjhjstz opened a new pull request, #1914:
URL: https://github.com/apache/cloudberry/pull/1914

   ```sql
   SET optimizer = on;
   SET optimizer_enable_multiple_distinct_aggs = on;
   
   EXPLAIN SELECT a, count(DISTINCT b) AS cnt_b, count(DISTINCT c) AS cnt_c
   FROM mdqa_part WHERE b BETWEEN 0 AND 2 GROUP BY a;
   
   Note: optimizer_enable_multiple_distinct_aggs is off by default; without it ORCA falls back before reaching the buggy code path.
   
   Error and stack trace (cassert build)
   
   CPhysicalCTEProducer.cpp:117: Failed assertion: col_ref->GetUsage() != CColRef::EUnknown
   Stack trace:
   1    gpos::CException::Raise + 278
   2    gpopt::CPhysicalCTEProducer::PcrsRequired + 380
   3    gpopt::CReqdPropPlan::ComputeReqdCols + 223
   4    gpopt::CReqdPropPlan::Compute + 153
   5    gpopt::CExpressionHandle::ComputeChildReqdProps + 515
   6    gpopt::CJobGroupExpressionOptimization::ComputeCurrentChildRequirements + 423
   7    gpopt::CJobGroupExpressionOptimization::ScheduleChildGroupsJobs + 236
   8    gpopt::CJobGroupExpressionOptimization::EevtOptimizeChildren + 115
   9    gpopt::CJobStateMachine + 376
   10   gpopt::CJobGroupExpressionOptimization::FExecute + 123
   11   gpopt::CScheduler::FExecute + 77
   12   gpopt::CScheduler::ExecuteJobs + 121
   13   gpopt::CScheduler::Run + 46
   14   gpopt::CEngine::Optimize + 919
   15   gpopt::COptimizer::PexprOptimize + 115
   16   gpopt::COptimizer::PdxlnOptimize + 1416
   17   COptTasks::OptimizeTask + 1651
   18   gpos::CTask::Execute + 202
   19   gpos::CWorker::Execute + 197
   20   gpos::CAutoTaskProxy::Execute + 227
   21   gpos_exec + 933
   
   LOG:  GPORCA failed to produce plan (unexpected)
   ```
   On release builds the assertion is compiled out and the same over-declared column list crashes later with SIGSEGV in MakeDXLTableDescr during DXL translation.
   
   
   Fixes #ISSUE_Number
   
   ### What does this PR do?
   <!-- Brief overview of the changes, including any major features or fixes -->
   
   ### Type of Change
   - [ ] Bug fix (non-breaking change)
   - [ ] New feature (non-breaking change)
   - [ ] Breaking change (fix or feature with breaking changes)
   - [ ] Documentation update
   
   ### Breaking Changes
   <!-- Remove if not applicable. If yes, explain impact and migration path -->
   
   ### Test Plan
   <!-- How did you test these changes? -->
   - [ ] Unit tests added/updated
   - [ ] Integration tests added/updated
   - [ ] Passed `make installcheck`
   - [ ] Passed `make -C src/test installcheck-cbdb-parallel`
   
   ### Impact
   <!-- Remove sections that don't apply -->
   **Performance:**
   <!-- Any performance implications? -->
   
   **User-facing changes:**
   <!-- Any changes visible to users? -->
   
   **Dependencies:**
   <!-- New dependencies or version changes? -->
   
   ### Checklist
   - [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
   - [ ] Added/updated documentation
   - [ ] Reviewed code for security implications
   - [ ] This PR contains AI-assisted code generation
   - [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
   
   ### Additional Context
   <!-- Any other information that would help reviewers? Remove if none -->
   
   ### CI Skip Instructions
   <!--
   To skip CI builds, add the appropriate CI skip identifier to your PR title.
   The identifier must:
   - Be in square brackets []
   - Include the word "ci" and either "skip" or "no"
   - Only use for documentation-only changes or when absolutely necessary
   -->
   
   ---
   <!-- Join our community:
   - Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
   - Discussions: https://github.com/apache/cloudberry/discussions -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] [ORCA] Narrow CTE Producer columns in CXformGbAggWithMDQA2Join [cloudberry]

Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz merged PR #1914:
URL: https://github.com/apache/cloudberry/pull/1914


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org