You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by he...@apache.org on 2019/12/05 22:11:49 UTC
[geode-benchmarks] branch GEODE-7554 created (now 9057a37)
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a change to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git.
at 9057a37 write each test only once
This branch includes the following new commits:
new fbe3102 write failed tests to file and update --ci readme
new 256a0a0 include NoopBenchmark
new 8ca991a fix append to failed file
new 8310931 close and flush the buffered writer
new 9057a37 write each test only once
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[geode-benchmarks] 04/05: close and flush the buffered writer
Posted by he...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git
commit 83109319e2561fca198456524b046aae9f6bc323
Author: Robert Houghton <rh...@pivotal.io>
AuthorDate: Thu Dec 5 12:50:43 2019 -0800
close and flush the buffered writer
Signed-off-by: Helena A. Bales <hb...@pivotal.io>
---
harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
index a9edb4f..0ab8785 100644
--- a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
+++ b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
@@ -98,6 +98,7 @@ public class Analyzer {
}
}
}
+ writer.close();
}
if (isCI && isHighWaterCandidate && isSignificantlyBetter) {
[geode-benchmarks] 03/05: fix append to failed file
Posted by he...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git
commit 8ca991a5b8eb6415dcb039b0e244df915f5dde93
Author: Helena A. Bales <hb...@pivotal.io>
AuthorDate: Thu Dec 5 10:48:35 2019 -0800
fix append to failed file
---
.../src/main/java/org/apache/geode/perftest/analysis/Analyzer.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
index 3f92507..a9edb4f 100644
--- a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
+++ b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
@@ -72,7 +72,7 @@ public class Analyzer {
benchmarkRunResult.writeResult(new PrintWriter(System.out));
/* throw exc if failed? */
- String errorFilePath = testResultArg + "/../failedTests";
+ String errorFilePath = testResultArg + "/../../failedTests";
BufferedWriter writer = new BufferedWriter(new FileWriter(errorFilePath, true));
boolean isSignificantlyBetter = false;
@@ -84,18 +84,19 @@ public class Analyzer {
if (isNaN(probeResult.baseline) || isNaN(probeResult.test)) {
errorMessage.append("BENCHMARK FAILED: ").append(benchmarkResult.name)
.append(" missing result file.\n");
+ writer.append(benchmarkResult.name + "\n");
} else if (probeResult.description.equals("average latency")) {
if (probeResult.getDifference() > 0) {
isHighWaterCandidate = false;
if (probeResult.getDifference() >= 0.05) {
errorMessage.append("BENCHMARK FAILED: ").append(benchmarkResult.name)
.append(" average latency is 5% worse than baseline.\n");
+ writer.append(benchmarkResult.name + "\n");
}
} else if (probeResult.getDifference() <= -0.5) {
isSignificantlyBetter = true;
}
}
- writer.append(benchmarkResult.name);
}
}
[geode-benchmarks] 01/05: write failed tests to file and update
--ci readme
Posted by he...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git
commit fbe3102f1bc4600a5f3d6c3ef07d47537f0560bd
Author: Helena A. Bales <hb...@pivotal.io>
AuthorDate: Thu Dec 5 09:51:43 2019 -0800
write failed tests to file and update --ci readme
---
.../src/main/java/org/apache/geode/perftest/analysis/Analyzer.java | 6 ++++++
infrastructure/scripts/aws/run_against_baseline.sh | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
index 13a90cc..3f92507 100644
--- a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
+++ b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
@@ -16,7 +16,9 @@ package org.apache.geode.perftest.analysis;
import static java.lang.Double.isNaN;
+import java.io.BufferedWriter;
import java.io.File;
+import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
@@ -70,6 +72,9 @@ public class Analyzer {
benchmarkRunResult.writeResult(new PrintWriter(System.out));
/* throw exc if failed? */
+ String errorFilePath = testResultArg + "/../failedTests";
+ BufferedWriter writer = new BufferedWriter(new FileWriter(errorFilePath, true));
+
boolean isSignificantlyBetter = false;
boolean isHighWaterCandidate = true;
StringBuilder errorMessage = new StringBuilder();
@@ -90,6 +95,7 @@ public class Analyzer {
isSignificantlyBetter = true;
}
}
+ writer.append(benchmarkResult.name);
}
}
diff --git a/infrastructure/scripts/aws/run_against_baseline.sh b/infrastructure/scripts/aws/run_against_baseline.sh
index f4e54fa..9681f58 100755
--- a/infrastructure/scripts/aws/run_against_baseline.sh
+++ b/infrastructure/scripts/aws/run_against_baseline.sh
@@ -129,7 +129,7 @@ while (( "$#" )); do
echo "-R|--baseline-geode-repo : Geode baseline repo (default: ${DEFAULT_BASELINE_REPO})"
echo "-B|--baseline-geode-branch : Geode baseline branch"
echo "-m|--metadata : Test metadata to output to file, comma-delimited"
- echo "--ci : Set if starting instances for Continuous Integration"
+ echo "--ci : Set if starting instances for Continuous Integration - used to retry failed tests and to name/target AWS instances"
echo "-- : All subsequent arguments are passed to the benchmark task as arguments."
echo "-h|--help|-? : This help message"
exit 1
[geode-benchmarks] 05/05: write each test only once
Posted by he...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git
commit 9057a37c29e65f5235e41d2247979098c9160534
Author: Helena A. Bales <hb...@pivotal.io>
AuthorDate: Thu Dec 5 13:06:02 2019 -0800
write each test only once
Signed-off-by: Robert Houghton <rh...@pivotal.io>
---
.../src/main/java/org/apache/geode/perftest/analysis/Analyzer.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
index 0ab8785..f4cca01 100644
--- a/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
+++ b/harness/src/main/java/org/apache/geode/perftest/analysis/Analyzer.java
@@ -84,22 +84,21 @@ public class Analyzer {
if (isNaN(probeResult.baseline) || isNaN(probeResult.test)) {
errorMessage.append("BENCHMARK FAILED: ").append(benchmarkResult.name)
.append(" missing result file.\n");
- writer.append(benchmarkResult.name + "\n");
} else if (probeResult.description.equals("average latency")) {
if (probeResult.getDifference() > 0) {
isHighWaterCandidate = false;
if (probeResult.getDifference() >= 0.05) {
errorMessage.append("BENCHMARK FAILED: ").append(benchmarkResult.name)
.append(" average latency is 5% worse than baseline.\n");
- writer.append(benchmarkResult.name + "\n");
}
} else if (probeResult.getDifference() <= -0.5) {
isSignificantlyBetter = true;
}
}
}
- writer.close();
+ writer.append(benchmarkResult.name + "\n");
}
+ writer.close();
if (isCI && isHighWaterCandidate && isSignificantlyBetter) {
System.out.println(
[geode-benchmarks] 02/05: include NoopBenchmark
Posted by he...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a commit to branch GEODE-7554
in repository https://gitbox.apache.org/repos/asf/geode-benchmarks.git
commit 256a0a09cecfa74810955f5c93e6630bd1cdd126
Author: Helena A. Bales <hb...@pivotal.io>
AuthorDate: Thu Dec 5 09:58:02 2019 -0800
include NoopBenchmark
---
geode-benchmarks/build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/geode-benchmarks/build.gradle b/geode-benchmarks/build.gradle
index 0abe0dc..946b0e1 100644
--- a/geode-benchmarks/build.gradle
+++ b/geode-benchmarks/build.gradle
@@ -65,7 +65,7 @@ task benchmark(type: Test) {
exclude "**/*NonIndexedQueryBenchmark.class"
exclude "**/PartitionedFunctionExecutionBenchmark.class"
- exclude "**/NoopBenchmark.class"
+// exclude "**/NoopBenchmark.class"
exclude "**/*LongBenchmark.class"
forkEvery 1