You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2017/09/18 20:07:34 UTC

[GitHub] storm pull request #2330: STORM-2742: Logviewer leaking file descriptors

GitHub user knusbaum opened a pull request:

    https://github.com/apache/storm/pull/2330

    STORM-2742: Logviewer leaking file descriptors

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knusbaum/incubator-storm STORM-2742

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2330
    
----
commit 1e81a907fd3722601e3d1e765baf4a9360b95e99
Author: Kyle Nusbaum <kn...@yahoo-inc.com>
Date:   2017-09-18T20:06:07Z

    Fix FD leak

----


---

[GitHub] storm issue #2330: STORM-2742: Logviewer leaking file descriptors

Posted by knusbaum <gi...@git.apache.org>.

Github user knusbaum commented on the issue:

    https://github.com/apache/storm/pull/2330
  
    I just added a try {...} finally {...} block. Not sure why the diff is so ugly.


---

[GitHub] storm pull request #2330: STORM-2742: Logviewer leaking file descriptors

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2330


---

[GitHub] storm issue #2330: STORM-2742: Logviewer leaking file descriptors

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2330
  
    +1 Maybe it is due to the reorganization of line sequences, but doesn't matter anyway.


---