[GitHub] [tinkerpop] skieffer opened a new pull request, #1733: gremlin-python: enable opt-out for some pkg reqs

[GitBox <gi...@apache.org>]

skieffer opened a new pull request, #1733:
URL: https://github.com/apache/tinkerpop/pull/1733

   For `gremlin-python` users who plan to use a custom transport, there may be no need to install the `aiohttp` or `nest_asyncio` packages. These packages bring quite a few recursive requirements with them as well.
   
   These packages should _not_ be moved to `extras_require` in `setup.py`, since this would break existing deployments.
   
   Instead, there is a pattern for opting out of requirements at installation time, using environment variables. It is discussed for example [here](https://github.com/aio-libs/aioredis-py/issues/663#issuecomment-555555554).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] skieffer commented on pull request #1733: gremlin-python: enable opt-out for some pkg reqs

[GitBox <gi...@apache.org>]

skieffer commented on PR #1733:
URL: https://github.com/apache/tinkerpop/pull/1733#issuecomment-1169368745

   Hi @krlawrence, thanks for taking a look at this.
   
   There are no dependency conflicts. For me the concern is partly about wasted MBs in a docker image (only about 12MB, but it counts), and partly about wanting to keep misleading clutter out of automatically generated licensing info. I don't want to say, "This software uses packages X, Y, and Z" if it doesn't actually use them.
   
   In any case, I realize the problem is really not with `gremlinpython` per se, but is fundamentally about needing better control over pip and dependency resolution. Therefore I'm trying to tackle the more general problem over at `pip-tools`: https://github.com/jazzband/pip-tools/pull/1645
   
   I think the latter would actually be my preferred solution, so, in the meantime, I guess I won't push too hard for this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] krlawrence commented on pull request #1733: gremlin-python: enable opt-out for some pkg reqs

[GitBox <gi...@apache.org>]

krlawrence commented on PR #1733:
URL: https://github.com/apache/tinkerpop/pull/1733#issuecomment-1167671348

   Is your main concern the size of the WHL file or are there conflicts created by the current dependency tree with the implementation that you are preferring to use for your web socket transport? I'm not opposed to this change but I think we will also need to add some tests as part of this PR for the flag, and potentially an alternate implementation as part of that testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #1733: gremlin-python: enable opt-out for some pkg reqs

[GitBox <gi...@apache.org>]

spmallette closed pull request #1733: gremlin-python: enable opt-out for some pkg reqs
URL: https://github.com/apache/tinkerpop/pull/1733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org