You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Andrew Grieve (JIRA)" <ji...@apache.org> on 2012/07/27 19:31:34 UTC

[jira] [Created] (CB-1150) Clean up iOS's exec to not pull out "options" object

Andrew Grieve created CB-1150:
---------------------------------

             Summary: Clean up iOS's exec to not pull out "options" object
                 Key: CB-1150
                 URL: https://issues.apache.org/jira/browse/CB-1150
             Project: Apache Cordova
          Issue Type: Improvement
          Components: iOS
            Reporter: Andrew Grieve
            Assignee: Andrew Grieve
            Priority: Minor
             Fix For: 2.1.0


This can be cleaned up by passing all params in exec as an array, and extracting the first dict only if the plugin implements the method:withDict: selector. Plugins that implement just method: will be passed the CDVInvokedUrlCommand directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1150) Clean up iOS's exec to not pull out "options" object

Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428176#comment-13428176 ] 

Andrew Grieve commented on CB-1150:
-----------------------------------

Updated plugins. commits:
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=0b9c472b53f85d0bf845db17b48314221fb4cd70
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=46ecf98c23110b427fc39c1c0e08a8b5d01367dd
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=b4c70c2e72bbe3d3a5056a682a79658b40f65610
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=09a3a48502acbc47b30b86ab926edf174d165b15
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=8e97f5001e2a16733357679d5bcfe98bbf379b3a
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=8da8fbc75470d1f11a464361e9af7e509573e95c
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=151a0f66093a61fbd87387eb8ebe93c6bb01ee27
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=886a4fc0283061abaaa7593befc8ff7767e4faf5
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=01eb22da37382be1b3944ede5e08a5ec9a6641d7
                
> Clean up iOS's exec to not pull out "options" object
> ----------------------------------------------------
>
>                 Key: CB-1150
>                 URL: https://issues.apache.org/jira/browse/CB-1150
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> This can be cleaned up by passing all params in exec as an array, and extracting the first dict only if the plugin implements the method:withDict: selector. Plugins that implement just method: will be passed the CDVInvokedUrlCommand directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-1150) Clean up iOS's exec to not pull out "options" object

Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424228#comment-13424228 ] 

Andrew Grieve commented on CB-1150:
-----------------------------------

Commits:
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=ad836cbb7afffe49ecc9f28708a910bd325d2527
https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=18e390f482ee5b16a7b90745339d69ac20de6e37

Still to do: Update Dev Guide (shazron)
Update remaining core plugins (agrieve)
                
> Clean up iOS's exec to not pull out "options" object
> ----------------------------------------------------
>
>                 Key: CB-1150
>                 URL: https://issues.apache.org/jira/browse/CB-1150
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> This can be cleaned up by passing all params in exec as an array, and extracting the first dict only if the plugin implements the method:withDict: selector. Plugins that implement just method: will be passed the CDVInvokedUrlCommand directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CB-1150) Clean up iOS's exec to not pull out "options" object

Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve resolved CB-1150.
-------------------------------

    Resolution: Fixed
    
> Clean up iOS's exec to not pull out "options" object
> ----------------------------------------------------
>
>                 Key: CB-1150
>                 URL: https://issues.apache.org/jira/browse/CB-1150
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> This can be cleaned up by passing all params in exec as an array, and extracting the first dict only if the plugin implements the method:withDict: selector. Plugins that implement just method: will be passed the CDVInvokedUrlCommand directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira