You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/22 14:37:24 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2588: WIP: Move SQL Query Planner into new `datafusion-sql` crate
andygrove opened a new pull request, #2588:
URL: https://github.com/apache/arrow-datafusion/pull/2588
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2345
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I would like the ability to have projects just depend on datafusion-sql if they are using DataFusion as a SQL parser + query planner and are not using it for execution.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Mostly just moving things around but there is also an API change to use TableSource instead of TableProvider in the schema provider trait that the SQL planner uses.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Yes, API change and new crate.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2588: Move SQL Query Planner into new `datafusion-sql` crate
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2588:
URL: https://github.com/apache/arrow-datafusion/pull/2588#issuecomment-1135012260
I didn't review the code of this PR but I like where it is heading -- thank you @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2588: WIP: Move SQL Query Planner into new `datafusion-sql` crate
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2588:
URL: https://github.com/apache/arrow-datafusion/pull/2588#discussion_r878892214
##########
datafusion/sql/src/planner.rs:
##########
@@ -4868,36 +4835,36 @@ mod tests {
#[test]
fn test_offset_no_limit() {
let sql = "SELECT id FROM person WHERE person.id > 100 OFFSET 5;";
- let expected = "Offset: 5\
- \n Projection: #person.id\
- \n Filter: #person.id > Int64(100)\
- \n TableScan: person projection=None";
+ let expected = "Offset: 3\
+ \n Limit: 5\
+ \n Projection: #person.id\
+ \n Filter: #person.id > Int64(100)\
+ \n TableScan: person projection=None";
quick_test(sql, expected);
}
#[test]
- fn test_offset_after_limit_with_limit_push() {
Review Comment:
We shouldn't be testing optimizer rules here, just the SQL query planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2588: Move SQL Query Planner into new `datafusion-sql` crate
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2588:
URL: https://github.com/apache/arrow-datafusion/pull/2588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2588: Move SQL Query Planner into new `datafusion-sql` crate
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2588:
URL: https://github.com/apache/arrow-datafusion/pull/2588#discussion_r878902366
##########
dev/release/README.md:
##########
@@ -379,15 +371,12 @@ We have published new versions of datafusion and ballista to crates.io:
https://crates.io/crates/datafusion/8.0.0
https://crates.io/crates/datafusion-cli/8.0.0
-https://crates.io/crates/datafusion-expr/8.0.0
https://crates.io/crates/datafusion-common/8.0.0
+https://crates.io/crates/datafusion-data-access/8.0.0
+https://crates.io/crates/datafusion-expr/8.0.0
https://crates.io/crates/datafusion-jit/8.0.0
https://crates.io/crates/datafusion-physical-expr/8.0.0
https://crates.io/crates/datafusion-proto/8.0.0
-https://crates.io/crates/datafusion-data-access/8.0.0
-https://crates.io/crates/ballista/0.7.0
Review Comment:
removing ballista here is not related to this PR but was missed earlier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org