You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by hbdeshmukh <gi...@git.apache.org> on 2017/01/22 17:16:02 UTC
[GitHub] incubator-quickstep pull request #166: Make the third party directory leaner
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/166
Make the third party directory leaner
- Added shell script to download prerequisite third party libs, instead
of relying on pre-existing source files in the third party directory.
- Deleted third party library code for some modules.
- Added re2 CMakeLists patch file.
- Ignore warnings during re2 compilation.
- Compilation fixes due to google benchmark upgrade.
- Fixes for the compilation error in Window aggregation unit test.
- Perform check for the current directory before running the third party
scripts.
- Created macro for setting GFLAG library name.
- Move third party source files to third_party/src directory.
- Update travis workflow.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hbdeshmukh/incubator-quickstep lean-third-party
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit 89f6f59078881e68b1916aab0dbd885512cd8cc6
Author: Harshad Deshmukh <hb...@apache.org>
Date: 2017-01-10T20:42:26Z
Make the third party directory leaner.
- Added shell script to download prerequisite third party libs, instead
of relying on pre-existing source files in the third party directory.
- Deleted third party library code for some modules.
- Added re2 CMakeLists patch file.
- Ignore warnings during re2 compilation.
- Compilation fixes due to google benchmark upgrade.
- Fixes for the compilation error in Window aggregation unit test.
- Perform check for the current directory before running the third party
scripts.
- Created macro for setting GFLAG library name.
- Move third party source files to third_party/src directory.
- Update travis workflow.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @hbdeshmukh,
I was wondering why we download release directly, instead of using submodules for `re2` and `gtest`? And, do we need to run the download shell script manually, or is it a part of `make` after generating `cmake` configurations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Well, you need to be consistent in [the document](https://github.com/apache/incubator-quickstep/blob/master/README.md#giving-it-a-spin) regarding this extra step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @hbdeshmukh,
While I am testing your branch on my Mac, could you please sync with the master? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
`cmake`'s [execute_process](https://cmake.org/cmake/help/latest/command/execute_process.html) would run a given script for you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Also, @hbdeshmukh, I ran it on my machine, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Sounds good @zuyu. Can you please create a PR to merge your fix to my branch https://github.com/hbdeshmukh/incubator-quickstep/tree/lean-third-party ? I will keep your commit as a separate commit in the branch, and then we can merge this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
I found two mail threads regarding this topic: `release: third_party/` and `Fixing git submodule commits to a release`. Do I still miss something, as I did not get the point of not using submodules?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @zuyu
I will request you to figure out a solution for the distributed issue, as you know it much better than anyone else. Any solution that you can make it to work should be fine. We should close this PR soon, as it has blocked our release. Thanks for your time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @zuyu
There was an elaborate discussion on the dev-list about this branch. Can you please refer to that instead of me reproducing it here? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @hbdeshmukh,
The `cmake` configure for the single node works, but it fails for the distributed version (assume both protobuf 3.0 and grpc are installed):
```
CMake Error at third_party/src/tmb/third_party/gflags/CMakeLists.txt:315 (add_dependencies):
Cannot add target-level dependencies to alias target "gflags".
```
After checkouting your own fork and the branch `lean-third-party`, what I did was:
```
$ git submodule update --init
$ cd third_party
$ ./download_and_patch_prerequisites.sh
$ cd ../build
$ cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_DISTRIBUTED=ON ..
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Combining CMake build process and downloading of third party libraries is not desirable. Here's the proposed workflow in the new branch:
1. Run download third party script (that also applies patches)
2. CMake (add subdirectories for third party libs and invoke Quickstep's CMake files)
3. make (build everything)
Note that 1 needs to be run only once. However 2 and 3 will be run over and over again as we continue development. If 1 and 2 are combined, we will repeatedly download third party libs and apply patches unnecessarily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
We need to run the script manually. I am not aware of a way through which make build process can do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @hbdeshmukh,
I have [a fix](https://github.com/apache/incubator-quickstep/pull/168/commits/66178d7e11543b0d4bac59481e4b7dfee034acd6) that downgrades `gflags` to 2.1.2, the version we currently use, from the latest. It also removed the trailing whitespace in the shell script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Synced. Thanks for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/166#discussion_r97817049
--- Diff: CMakeLists.txt ---
@@ -694,8 +698,9 @@ else()
include_directories(${CMAKE_CURRENT_BINARY_DIR}/third_party)
endif()
-add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2_cmake" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
+#add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2_cmake" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
include_directories("${THIRD_PARTY_SOURCE_DIR}/re2")
+add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
--- End diff --
Removed the dead code. If I change the order of 702 and 703, it gives me following error, and hence include first and add subdirectory later.
```
...third_party/src/re2/re2/bitstate.cc:24:26: fatal error: util/logging.h: No such file or directory
#include "util/logging.h"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
In the last two builds, one of GCC jobs failed due to the time out. Is there a workaround?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu Once this PR is merged, I will change the instructions for building Quickstep.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @hbdeshmukh,
I think I don't have the permission to push to your fork, but I have the following suggestions for you to do the same thing in your local fork, assuming in the local clone of `hbdeshmukh/incubator-quickstep`, not the `asf` repo:
```
$ git remote add zuyu https://github.com/zuyu/incubator-quickstep.git
$ git fetch zuyu lean-third-party
$ git push origin lean-third-party
```
Let me know if you have questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Why can't TMB use the gflags library from Quickstep's 3rd party libraries?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #166: Make the third party directory leaner
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/166#discussion_r97736364
--- Diff: CMakeLists.txt ---
@@ -694,8 +698,9 @@ else()
include_directories(${CMAKE_CURRENT_BINARY_DIR}/third_party)
endif()
-add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2_cmake" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
+#add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2_cmake" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
include_directories("${THIRD_PARTY_SOURCE_DIR}/re2")
+add_subdirectory ("${THIRD_PARTY_SOURCE_DIR}/re2" "${CMAKE_CURRENT_BINARY_DIR}/third_party/re2")
--- End diff --
Per the conventional usage in this file, please move this `add_subdirectory` before `include_directories`, while deleting the old `add_subdirectory`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
I understand the proposal, and my suggestion is to avoid the extra step 1. There should have a way in step 3 to run once the download script and apply patches (i.e., check for whether a particular file created by the script exists), while building files as many as the dev likes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Though, I would say, one enhancement we can do right now, is check that the user has `curl` and stop the script if they don't.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
> Though, I would say, one enhancement we can do right now, is check that the user has curl and stop the script if they don't.
I have added the checks for the existence of ``curl`` and ``tar``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Hi @hbdeshmukh,
It seems that `third_party/src/gflags` and `tmb/third_party/gflags` are different versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Yes.
On Wed, Jan 25, 2017 at 6:24 PM Marc S <no...@github.com> wrote:
> @zuyu <https://github.com/zuyu> are you suggesting that the cmake command
> should automatically run the download script?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-quickstep/pull/166#issuecomment-275293116>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACJDxIJ3TwJ4L-fdItreIueXHjqXTu-Xks5rWAPrgaJpZM4LqcM_>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu are you suggesting that the `cmake` command should automatically run the download script?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
>I understand the proposal, and my suggestion is to avoid the extra step 1. There should have a way in step 3 to run once the download script and apply patches (i.e., check for whether a particular file created by the script exists), while building files as many as the dev likes.
I am unable to understand your point. What's the problem with the download step that you have to perform only once in your development lifecycle? As I said earlier, making cmake and make build processes complicated is not desired.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
I am assuming you are talking about [build 724 for PR#167](https://travis-ci.org/apache/incubator-quickstep/builds/195394320) and [build 725 for this PR](https://travis-ci.org/apache/incubator-quickstep/builds/196001823).
I am not sure why one specific gcc build is timing out. With regards to the changes in this PR, the download and unzip process finishes quickly (1-2 seconds), so the overhead isn't high, if that's what you are asking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
It should be possible. Do you know how to do that?
On the other hand, if tmb builds gflags as a shared library, it would work.
On Sat, Jan 28, 2017 at 9:47 AM Harshad Deshmukh <no...@github.com>
wrote:
> Why can't TMB use the gflags library from Quickstep's 3rd party libraries?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-quickstep/pull/166#issuecomment-275862740>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACJDxJT4pkJd55fcDgxncRXxibSTKIo-ks5rW38pgaJpZM4LqcM_>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
Done. Travis somehow determined that there was a previous build and therefore didn't trigger another build, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
@zuyu I think that's a good idea. Maybe though, that could be a version 2 feature. Seeing as before we had 3 commands with `submodule`, this is an improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #166: Make the third party directory leaner
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/166
LGTM. Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---