You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Thomas Eibner <th...@stderr.net> on 2001/10/06 23:44:16 UTC
[PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
To get my module mod_rpaf working on NetWare / Win32 the linker defs
need a patch.
Patches attached.
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by Thomas Eibner <th...@stderr.net>.
On Sun, Oct 07, 2001 at 08:04:27AM +0200, Thomas Eibner wrote:
> On Sun, Oct 07, 2001 at 12:02:45AM -0500, William A. Rowe, Jr. wrote:
> > To clarify... I mean the Win32's and Netware's exports lists, and the
> > appropriate API_EXPORT[_NONSTD] definitions. In other words, make this
> > patch fix this lists, including the sources, and do nothing else.
>
> What are the exact rules for using API_EXPORT and API_EXPORT_NONSTD?
>
> I can see that some functions use API_EXPORT for an int and others use
> API_EXPORT_NONSTD for an int, is there any reasoning behind this or did
> I just not dig long enough on this yet?
*Doh* should go to bed, it wasn't that part on NONSTD or not I didn't
get, it was the mixed use of CORE_EXPORT and API_EXPORT.
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by Thomas Eibner <th...@stderr.net>.
On Sun, Oct 07, 2001 at 12:02:45AM -0500, William A. Rowe, Jr. wrote:
> To clarify... I mean the Win32's and Netware's exports lists, and the
> appropriate API_EXPORT[_NONSTD] definitions. In other words, make this
> patch fix this lists, including the sources, and do nothing else.
What are the exact rules for using API_EXPORT and API_EXPORT_NONSTD?
I can see that some functions use API_EXPORT for an int and others use
API_EXPORT_NONSTD for an int, is there any reasoning behind this or did
I just not dig long enough on this yet?
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
From: "William A. Rowe, Jr." <wr...@covalent.net>
Sent: Saturday, October 06, 2001 11:47 PM
> From: "Thomas Eibner" <th...@stderr.net>
> Sent: Saturday, October 06, 2001 6:17 PM
>
> > On Sat, Oct 06, 2001 at 05:36:49PM -0500, William A. Rowe, Jr. wrote:
>
> > > I don't know that I have any other objections to exporting
> > > ap_update_vhost_from_headers. There are actually several symbols
> > > in support/httpd.exp that might be added. I tend to believe we
> > > aught to simply any missing items from list (with appropriate
> > > API_EXPORTs.)
> >
> > Want me to supply a similar patch for the missing items from the list?
>
> With the caviat --- we won't reexport symbols present in the other
> libraries [the users can always bind to expat or regex directly.]
>
> Sure :) If you can consistify the netware's .imp and win32's .def
> to that httpd list, that would be very cool. I'd just apply the entire
> list at once, so please don't change anything other than that list of
> symbols.
To clarify... I mean the Win32's and Netware's exports lists, and the
appropriate API_EXPORT[_NONSTD] definitions. In other words, make this
patch fix this lists, including the sources, and do nothing else.
There's a long history of frustration when folks submit patches to do
2+ things ... so I simply meant to warn you against doing so :)
Bill
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by Thomas Eibner <th...@stderr.net>.
On Sat, Oct 06, 2001 at 11:47:42PM -0500, William A. Rowe, Jr. wrote:
> > Like the attached patches?
>
> Bingo :)
>
> > > I don't know that I have any other objections to exporting
> > > ap_update_vhost_from_headers. There are actually several symbols
> > > in support/httpd.exp that might be added. I tend to believe we
> > > aught to simply any missing items from list (with appropriate
> > > API_EXPORTs.)
> >
> > Want me to supply a similar patch for the missing items from the list?
>
> With the caviat --- we won't reexport symbols present in the other
> libraries [the users can always bind to expat or regex directly.]
>
> Sure :) If you can consistify the netware's .imp and win32's .def
> to that httpd list, that would be very cool. I'd just apply the entire
> list at once, so please don't change anything other than that list of
> symbols.
>
> Don't forget to declare them appropriately. If they use non-std args,
> e.g. (int foo, ...) then we need to declare them API_EXPORT_NONSTD.
> Data is also a bit different. Since you created the patch, I presume
> you already know these things.
>
> No sense in having platforms with mismatching exports.
You want the ones I already did in that patch too?
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
From: "Thomas Eibner" <th...@stderr.net>
Sent: Saturday, October 06, 2001 6:17 PM
> On Sat, Oct 06, 2001 at 05:36:49PM -0500, William A. Rowe, Jr. wrote:
> > Win32 also needs the appropriate API_EXPORT macros around the
> > prototype and declaration of ap_update_vhost_from_headers.
>
> Like the attached patches?
Bingo :)
> > I don't know that I have any other objections to exporting
> > ap_update_vhost_from_headers. There are actually several symbols
> > in support/httpd.exp that might be added. I tend to believe we
> > aught to simply any missing items from list (with appropriate
> > API_EXPORTs.)
>
> Want me to supply a similar patch for the missing items from the list?
With the caviat --- we won't reexport symbols present in the other
libraries [the users can always bind to expat or regex directly.]
Sure :) If you can consistify the netware's .imp and win32's .def
to that httpd list, that would be very cool. I'd just apply the entire
list at once, so please don't change anything other than that list of
symbols.
Don't forget to declare them appropriately. If they use non-std args,
e.g. (int foo, ...) then we need to declare them API_EXPORT_NONSTD.
Data is also a bit different. Since you created the patch, I presume
you already know these things.
No sense in having platforms with mismatching exports.
Bill
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by Thomas Eibner <th...@stderr.net>.
On Sat, Oct 06, 2001 at 05:36:49PM -0500, William A. Rowe, Jr. wrote:
> Win32 also needs the appropriate API_EXPORT macros around the
> prototype and declaration of ap_update_vhost_from_headers.
Like the attached patches?
> I don't know that I have any other objections to exporting
> ap_update_vhost_from_headers. There are actually several symbols
> in support/httpd.exp that might be added. I tend to believe we
> aught to simply any missing items from list (with appropriate
> API_EXPORTs.)
Want me to supply a similar patch for the missing items from the list?
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
Win32 also needs the appropriate API_EXPORT macros around the
prototype and declaration of ap_update_vhost_from_headers.
I don't know that I have any other objections to exporting
ap_update_vhost_from_headers. There are actually several symbols
in support/httpd.exp that might be added. I tend to believe we
aught to simply any missing items from list (with appropriate
API_EXPORTs.)
Comments?
Bill
----- Original Message -----
From: "Thomas Eibner" <th...@stderr.net>
To: <de...@httpd.apache.org>
Sent: Saturday, October 06, 2001 4:44 PM
Subject: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
> To get my module mod_rpaf working on NetWare / Win32 the linker defs
> need a patch.
> Patches attached.
>
> --
> Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
> mod_pointer <http://stderr.net/mod_pointer>
>
>