[GitHub] [superset] aniaan commented on a change in pull request #16624: fix(dataset): create ES-View dataset raise exception #16623

[GitBox <gi...@apache.org>]

aniaan commented on a change in pull request #16624:
URL: https://github.com/apache/superset/pull/16624#discussion_r705016866



##########
File path: superset/db_engine_specs/base.py
##########
@@ -1343,6 +1343,21 @@ def cancel_query(cls, cursor: Any, query: Query, cancel_query_id: str) -> bool:
 
         return False
 
+    @classmethod
+    def _has_view(
+        cls,
+        conn: Connection,
+        dialect: Dialect,
+        view_name: str,
+        schema: Optional[str] = None,
+    ):
+        view_names = dialect.get_view_names(connection=conn, schema=schema)

Review comment:
       I fixed, please review




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org