You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/02/28 23:10:58 UTC

Review Request 57173: ATLAS-1606: Atlas query provider instead of hardcoded queries

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57173/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.


Bugs: ATLAS-1606
    https://issues.apache.org/jira/browse/ATLAS-1606


Repository: atlas


Description
-------

Adds a provider to distinguish queries for Gremlin2 and Gremlin3


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 6b7d7d3e 
  repository/src/main/java/org/apache/atlas/services/MetricsService.java 7de9bd04 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java cf85b2fc 
  webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java 1e98232f 

Diff: https://reviews.apache.org/r/57173/diff/


Testing
-------

mvn clean package executes successfully.


Thanks,

Apoorv Naik


Re: Review Request 57173: ATLAS-1606: Atlas query provider instead of hardcoded queries

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57173/#review167199
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 28, 2017, 11:10 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57173/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 11:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1606
>     https://issues.apache.org/jira/browse/ATLAS-1606
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Adds a provider to distinguish queries for Gremlin2 and Gremlin3
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 6b7d7d3e 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 7de9bd04 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java cf85b2fc 
>   webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java 1e98232f 
> 
> Diff: https://reviews.apache.org/r/57173/diff/
> 
> 
> Testing
> -------
> 
> mvn clean package executes successfully.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>