[GitHub] [spark] Ngone51 commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

[GitBox <gi...@apache.org>]

Ngone51 commented on pull request #29002:
URL: https://github.com/apache/spark/pull/29002#issuecomment-656154660


   > So If we reorder the initialization, it should be placed before the registration, not after heartbeater started right?
   
   Ideally, that way should work as well. However, it seems plugin initialization relies on some internal instances of `Executor`. So, if we want to initialize plugin out of the executor, I'm afraid we need more changes.
   
   BTW, I think your current implementation can already work as I mentioned above.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org