You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/17 11:38:13 UTC
[GitHub] [flink] TsReaper opened a new pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
TsReaper opened a new pull request #12924:
URL: https://github.com/apache/flink/pull/12924
## What is the purpose of the change
In `BinaryWriter`, we have special logic when dealing null values of `DecimalType` and `TimestampType`. However, the currently deprecated (but still largely in use) `setNullAt` method cannot determine the type of the specified field so this method cannot handle `DecimalType` and `TimestampType` correctly, thus causing the bug in FLINK-14848.
This PR remove deprecated `setNullAt` and `write` methods in `BinaryWriter` and use `NullSetter`/`ValueSetter` to replace them.
## Brief change log
- Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead.
## Verifying this change
This change is already covered by existing tests (including binary writer tests, serializer tests, IT cases involving code generation, etc.). This PR also adds some test cases for verifying.
Note that this PR removes two test cases in which Kryo serializers are specified in the `ExecutionConfig`. This feature is not supported in table API.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: yes, but they're still compatible
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
}, {
"hash" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4731",
"triggerID" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af37554f3ea8bf91dfc07ee91413ef1f2024529c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4731)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
}, {
"hash" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ece5016b9216da2d20aeaab35a267f4cbe153458 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718)
* af37554f3ea8bf91dfc07ee91413ef1f2024529c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df4b30160327e908ef6762a9cb4c43c39f177afb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df4b30160327e908ef6762a9cb4c43c39f177afb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df4b30160327e908ef6762a9cb4c43c39f177afb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595)
* 742d335b610aaba0d02e508907d0c6e7e19fbc07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 742d335b610aaba0d02e508907d0c6e7e19fbc07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621)
* ece5016b9216da2d20aeaab35a267f4cbe153458 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 742d335b610aaba0d02e508907d0c6e7e19fbc07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df4b30160327e908ef6762a9cb4c43c39f177afb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* df4b30160327e908ef6762a9cb4c43c39f177afb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595)
* 742d335b610aaba0d02e508907d0c6e7e19fbc07 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 742d335b610aaba0d02e508907d0c6e7e19fbc07 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621)
* ece5016b9216da2d20aeaab35a267f4cbe153458 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
}, {
"hash" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4731",
"triggerID" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af37554f3ea8bf91dfc07ee91413ef1f2024529c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4731)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
}, {
"hash" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4731",
"triggerID" : "af37554f3ea8bf91dfc07ee91413ef1f2024529c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ece5016b9216da2d20aeaab35a267f4cbe153458 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718)
* af37554f3ea8bf91dfc07ee91413ef1f2024529c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4731)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660060634
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit df4b30160327e908ef6762a9cb4c43c39f177afb (Fri Jul 17 11:40:09 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14848).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12924: [FLINK-14848][table] Remove deprecated setNullAt/write in BinaryWriter and use NullSetter/ValueSetter instead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12924:
URL: https://github.com/apache/flink/pull/12924#issuecomment-660075541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4595",
"triggerID" : "df4b30160327e908ef6762a9cb4c43c39f177afb",
"triggerType" : "PUSH"
}, {
"hash" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4621",
"triggerID" : "742d335b610aaba0d02e508907d0c6e7e19fbc07",
"triggerType" : "PUSH"
}, {
"hash" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718",
"triggerID" : "ece5016b9216da2d20aeaab35a267f4cbe153458",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ece5016b9216da2d20aeaab35a267f4cbe153458 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org