You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/04 20:44:56 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6624: NIFI-10768 Filter empty messages in ListenSyslog

exceptionfactory opened a new pull request, #6624:
URL: https://github.com/apache/nifi/pull/6624

   # Summary
   
   [NIFI-10768](https://issues.apache.org/jira/browse/NIFI-10768) Updates the `ListenSyslog` Processor to discard incoming messages consisting of zero bytes.
   
   This behavior can occur when the `Parse Messages` property is disabled. Changes include a new test method to send a batch of messages with an empty message to confirm expected behavior. The implementation adds a `FilteringStrategy` argument to the generic Server Factory to support the potential for other components to implement similar behavior.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6624: NIFI-10768 Filter empty messages in ListenSyslog

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6624:
URL: https://github.com/apache/nifi/pull/6624#issuecomment-1306124674

   All looks good. Was able to run a few tests locally and saw expected behavior. All GitHub actions also check out. +1 merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6624: NIFI-10768 Filter empty messages in ListenSyslog

Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6624:
URL: https://github.com/apache/nifi/pull/6624#issuecomment-1304259645

   Thanks @exceptionfactory code looks good to me. Will wait for Github Actions to complete and then can merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markap14 merged pull request #6624: NIFI-10768 Filter empty messages in ListenSyslog

Posted by GitBox <gi...@apache.org>.
markap14 merged PR #6624:
URL: https://github.com/apache/nifi/pull/6624


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org