You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/18 03:01:33 UTC
[GitHub] [dolphinscheduler] lordk911 opened a new issue #8976: [Feature][processdefine] use unique index
lordk911 opened a new issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
because of bug https://github.com/apache/dolphinscheduler/issues/8790 , the database could be contaminated
the database constraint should be the last line of defense.
ID can be use as no business logic primary key , and business logic primary key can be use as unique index.
something like this:
```
ALTER TABLE
`dolphinscheduler`.`t_ds_task_definition` ADD CONSTRAINT uidx_tdef_cv UNIQUE (`code`,
`version`)
```
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8976: [Feature][processdefine] use unique index
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976#issuecomment-1072025311
It's a good idea, and I think the unique index should also add in `t_ds_task_definition_log`.
What do you think? @JinyLeeChina @lordk911 @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8976: [Feature][processdefine] use unique index
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976#issuecomment-1072025311
It's a good idea, and I think the unique index should also add in `t_ds_task_definition_log`.
What do you think? @JinyLeeChina @lordk911 @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #8976: [Feature][processdefine] use unique index
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976#issuecomment-1072051514
> It's a good idea, and I think the unique index should also add in `t_ds_task_definition_log`. What do you think? @JinyLeeChina @lordk911 @SbloodyS
I think it's a good idea too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8976: [Feature][processdefine] use unique index
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976#issuecomment-1071980903
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8976: [Feature][processdefine] use unique index
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976#issuecomment-1071980903
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #8976: [Feature][processdefine] use unique index
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #8976:
URL: https://github.com/apache/dolphinscheduler/issues/8976#issuecomment-1072051514
> It's a good idea, and I think the unique index should also add in `t_ds_task_definition_log`. What do you think? @JinyLeeChina @lordk911 @SbloodyS
I think it's a good idea too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org