You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/03 13:42:53 UTC
[GitHub] draksler commented on a change in pull request #3733: [AIRFLOW-491]
Add cache parameter in BigQuery query method - with 'api_resource_configs'
draksler commented on a change in pull request #3733: [AIRFLOW-491] Add cache parameter in BigQuery query method - with 'api_resource_configs'
URL: https://github.com/apache/incubator-airflow/pull/3733#discussion_r238271833
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -473,11 +482,11 @@ def create_external_table(self,
def run_query(self,
bql=None,
sql=None,
- destination_dataset_table=False,
+ destination_dataset_table=None,
write_disposition='WRITE_EMPTY',
allow_large_results=False,
- flatten_results=None,
- udf_config=False,
+ flatten_results=False,
Review comment:
This breaks the BigQueryOperator which sets the udf_config to false when it calls the hook.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services