You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/05/27 07:42:19 UTC

[GitHub] [openwhisk-vscode-extension] style95 opened a new pull request #9: Add scancode

style95 opened a new pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-vscode-extension] upgle commented on a change in pull request #9: Add scancode

Posted by GitBox <gi...@apache.org>.
upgle commented on a change in pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640396982



##########
File path: resource/template/actioncode/sample.js
##########
@@ -1,3 +1,20 @@
+/*

Review comment:
       This is not a test code. When a user creates a new action with the plugin, this sample code is used.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-vscode-extension] style95 commented on a change in pull request #9: Add scancode

Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640399959



##########
File path: resource/template/actioncode/sample.js
##########
@@ -1,3 +1,20 @@
+/*

Review comment:
       I feel it's reasonable to add a license header as this code is also provided by asf?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-vscode-extension] style95 commented on a change in pull request #9: Add scancode

Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640394126



##########
File path: resource/template/actioncode/sample.js
##########
@@ -1,3 +1,20 @@
+/*

Review comment:
       This is according to the [scancode](https://github.com/apache/openwhisk-utilities/blob/master/scancode/scanCode.py).
   Even test codes in the openwhisk repo have a license header.
   https://github.com/apache/openwhisk/blob/master/tests/dat/actions/echo.js




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-vscode-extension] style95 merged pull request #9: Add scancode

Posted by GitBox <gi...@apache.org>.
style95 merged pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-vscode-extension] upgle commented on a change in pull request #9: Add scancode

Posted by GitBox <gi...@apache.org>.
upgle commented on a change in pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640392131



##########
File path: resource/template/actioncode/sample.js
##########
@@ -1,3 +1,20 @@
+/*

Review comment:
       I'd liked to know the license is required for a sample code.
   I am not sure about the licensing policy.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-vscode-extension] style95 commented on a change in pull request #9: Add scancode

Posted by GitBox <gi...@apache.org>.
style95 commented on a change in pull request #9:
URL: https://github.com/apache/openwhisk-vscode-extension/pull/9#discussion_r640394126



##########
File path: resource/template/actioncode/sample.js
##########
@@ -1,3 +1,20 @@
+/*

Review comment:
       This is according to the `scancode.sh`.
   Even test codes in the openwhisk repo have a license header.
   https://github.com/apache/openwhisk/blob/master/tests/dat/actions/echo.js




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org