You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/19 09:07:55 UTC
[GitHub] [doris] morningman opened a new pull request, #11007: [refactor](policy) refactor some policy create and check logic
morningman opened a new pull request, #11007:
URL: https://github.com/apache/doris/pull/11007
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
1. Remove `Config.default_storage_policy`
Now the Doris will create default storage policy when first startup, and name is `default_storage_policy`
2. Do not call `Catalog.getCurrentCatalog().getNextId()` in Policy's constructors.
Pass the policy id from outside, so that we can safely create a new policy instance anywhere.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
The config has been removed
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11007: [refactor](policy) refactor some policy create and check logic
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11007:
URL: https://github.com/apache/doris/pull/11007#issuecomment-1188854300
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] deardeng commented on pull request #11007: [refactor](policy) refactor some policy create and check logic
Posted by GitBox <gi...@apache.org>.
deardeng commented on PR #11007:
URL: https://github.com/apache/doris/pull/11007#issuecomment-1188847901
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11007: [refactor](policy) refactor some policy create and check logic
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11007:
URL: https://github.com/apache/doris/pull/11007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org