Re: [PR] KAFKA-19932: adding handling of OOM and avoiding wrapped as timeout [kafka]

["iit2009060 (via GitHub)" <gi...@apache.org>]

iit2009060 commented on code in PR #21117:
URL: https://github.com/apache/kafka/pull/21117#discussion_r2877548994


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -956,7 +955,10 @@ private void handleTimeoutFailure(long now, Throwable cause) {
                 log.debug("{} timed out at {} after {} attempt(s)", this, now, tries,
                     new Exception(prettyPrintException(cause)));
             }
-            if (cause instanceof TimeoutException) {
+            // Don't mask OutOfMemoryError as TimeoutException - propagate it directly
+            if (cause instanceof OutOfMemoryError) {

Review Comment:
   @Nikita-Shupletsov  I am moving Out of memory error out of Timeout  as out of memory is not a retryable error. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org